added sanitization of samples with negative value #3627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Comment on lines
+1334
to
+1338
| for i := range x.Value { | ||
| if x.Value[i] < 0 { | ||
| x.Value[i] = 0 | ||
| } | ||
| } |
There was a problem hiding this comment.
This is a little bit more complicated: we already do this sanitisation outside this function, in https://github.com/grafana/pyroscope/blob/main/pkg/pprof/pprof.go#L390-L394
In ad-hoc, profiles travel a different path, and this is handled here actually:
https://github.com/grafana/pyroscope/blob/main/pkg/og/structs/flamebearer/convert/convert.go#L205
There was a problem hiding this comment.
Thanks for the contribution @Pickausernaame! Could you please sign CLA and review comments? Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3616