Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primary label selection: Better empty volume UI #835

Merged
merged 8 commits into from
Oct 17, 2024

Conversation

gtk-grafana
Copy link
Contributor

@gtk-grafana gtk-grafana commented Oct 17, 2024

Fixes: #834

image

Now empty search results should only show if the user has an active search:
image

@gtk-grafana gtk-grafana marked this pull request as ready for review October 17, 2024 16:15
@gtk-grafana gtk-grafana requested a review from a team as a code owner October 17, 2024 16:15
Co-authored-by: Matias Chomicki <matyax@gmail.com>
Copy link
Contributor

@matyax matyax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected 👌

@gtk-grafana gtk-grafana merged commit 7aa8072 into main Oct 17, 2024
4 checks passed
@gtk-grafana gtk-grafana deleted the gtk-grafana/issues/834/empty-volume-ui branch October 17, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nit: No service matched your search when I've added 'database'
2 participants