-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pages: Breakdown routes #477
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1/location-history
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
…1/location-history
…upported error" This reverts commit 4733a35.
gtk-grafana
commented
Jun 27, 2024
gtk-grafana
commented
Jun 27, 2024
gtk-grafana
commented
Jun 27, 2024
…1/location-history
This was referenced Jul 1, 2024
matyax
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works perfectly for me, amazing job! Left mostly minor comments and suggestions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #351
Fixes: #462
Adding routes for the breakdown pages:
Services index:
/a/grafana-lokiexplore-app/explore
Breakdown:
/a/grafana-lokiexplore-app/explore/service/:service/:breakdownSlug
e.g.:
This PR will allow users to use the browser history to go back or forward to breakdown or index pages, instead of the whole app having essentially a single entry in the browser history.
Breadcrumbs should remain unchanged, functionality should be mostly unchanged as well.
This includes clearing the filters when removing the service. It might be possible to keep filters cached, so when users removing a service, and then add it again, the previous filters are applied, but the breakdown pages cache filters individually, so when a filter was removed from a single breakdown, and then the service removed, and then re-added, each breakdown would have different filters cached, although they weren't in the URL, so weren't being applied to the query, which was buggy. If we could figure out how to have a single cache for all filters in breakdown routes, users might not need to go back in the browser history as much, as filters would be cached to the service slug.
Functionality that did change:
Notes:
Follow ups (in another PR):