Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OboeTester: Create foreground service #2071

Merged
merged 6 commits into from
Jul 12, 2024
Merged

OboeTester: Create foreground service #2071

merged 6 commits into from
Jul 12, 2024

Conversation

robertwu1
Copy link
Collaborator

Fixes #2065

@robertwu1 robertwu1 requested a review from philburk July 11, 2024 22:11
atneya
atneya approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@atneya atneya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

philburk
philburk requested changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@philburk philburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For testing and debugging, we need to retain the ability to test what happens if you do NOT start a ForegroundService. So please add another checkbox on MainActivity screen below "enable background operation" labelled "use foregroundService".

apps/OboeTester/app/src/main/java/com/mobileer/oboetester/MainActivity.java Outdated Show resolved Hide resolved
apps/OboeTester/app/src/main/java/com/mobileer/oboetester/AudioForegroundService.java Outdated Show resolved Hide resolved
@robertwu1 robertwu1 requested a review from philburk July 11, 2024 23:01
philburk
philburk approved these changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@philburk philburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What notification does the user see?

@robertwu1
Copy link
Collaborator Author

Screenshot_20240712-110941~2
Screenshot_20240712-110951

@robertwu1 robertwu1 merged commit 3e468f5 into main Jul 12, 2024
3 checks passed
@robertwu1 robertwu1 deleted the robertwu/oboetesterforegroundservice branch July 12, 2024 18:16
@robertwu1 robertwu1 mentioned this pull request Jul 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philburk philburk philburk approved these changes

@atneya atneya atneya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a foreground service to OboeTester
3 participants
@robertwu1 @philburk @atneya