Add RegistrarUpdateHistory objects for console changes

[gbrodman]

This change is 

[ptkach]

Reviewed 7 of 13 files at r1, all commit messages.
Reviewable status: 7 of 13 files reviewed, 4 unresolved discussions (waiting on @gbrodman)

---

core/src/main/java/google/registry/ui/server/console/ConsoleApiAction.java line 267 at r1 (raw file):

  }

  protected void finishAndPersistConsoleUpdateHistory(ConsoleUpdateHistory.Builder<?, ?> builder) {

Do we want to log the response? It'd def be helpful, although might present a separate complexities for when we send sensitive data in response

---

core/src/main/java/google/registry/ui/server/console/ConsoleEppPasswordAction.java line 59 at r1 (raw file):

      new PasswordOnlyTransportCredentials();
  private final AuthenticatedRegistrarAccessor registrarAccessor;
  private final Gson gson;

At this point I wonder if it'd make sense to make gson a part of consoleApiParams?

---

core/src/main/java/google/registry/ui/server/console/ConsoleEppPasswordAction.java line 118 at r1 (raw file):

                      .setType(ConsoleUpdateHistory.Type.REGISTRAR_UPDATE)
                      .setRegistrar(updatedRegistrar)
                      .setRequestBody(gson.toJson(eppRequestBody)));

Hmm I'm not so sure about this one - eppRequestBody contains sensitive information and storing it in db as a plain text is...questionable?

---

core/src/main/java/google/registry/ui/server/console/ConsoleUpdateRegistrarAction.java line 57 at r1 (raw file):

  ConsoleUpdateRegistrarAction(
      ConsoleApiParams consoleApiParams,
      Gson gson,

Same as others - probably worth making it a part of consoleApiParams, refactoring it out later will be more difficult if this is merged

[gbrodman]

Reviewable status: 1 of 30 files reviewed, 4 unresolved discussions (waiting on @ptkach)

---

core/src/main/java/google/registry/ui/server/console/ConsoleApiAction.java line 267 at r1 (raw file):

Previously, ptkach (Pavlo Tkach) wrote…

Do we want to log the response? It'd def be helpful, although might present a separate complexities for when we send sensitive data in response

Yeah, I think it might not be super useful to log the response since we're also saving the state of the entity at that time.

---

core/src/main/java/google/registry/ui/server/console/ConsoleEppPasswordAction.java line 59 at r1 (raw file):

Previously, ptkach (Pavlo Tkach) wrote…

At this point I wonder if it'd make sense to make gson a part of consoleApiParams?

Done.

---

core/src/main/java/google/registry/ui/server/console/ConsoleEppPasswordAction.java line 118 at r1 (raw file):

Previously, ptkach (Pavlo Tkach) wrote…

Hmm I'm not so sure about this one - eppRequestBody contains sensitive information and storing it in db as a plain text is...questionable?

yeah, the more I'm thinking about it the more we probably might just want to remove that field from the DB entirely. Probably we could also remove the HTTP method as well (since it's probably not going to be useful)

Thoughts?

---

core/src/main/java/google/registry/ui/server/console/ConsoleUpdateRegistrarAction.java line 57 at r1 (raw file):

Previously, ptkach (Pavlo Tkach) wrote…

Same as others - probably worth making it a part of consoleApiParams, refactoring it out later will be more difficult if this is merged

Done.