Add pre-commit and associated CI #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
peytondmurray
force-pushed
the
17-lint-workflow
branch
from
1a2da86
to
f307041
Compare
peytondmurray
changed the title
smokestacklightnin
pushed a commit
to smokestacklightnin/ml-metadata
that referenced
this pull request
Oct 15, 2024
Add pre-commit and associated CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
pre-commit-config.yamland an associated CI job to run pre-commit on all PRs. Additionally:.gitignorewas added to the project becausepre-commituses it to know which files should be lintedpre-commitdependency:ml-metadata[lint]pyproject.toml. Many rules we don't want to ignore have been ignored because of violations in the existing code.CONTRIBUTING.mdI'm leaving this PR as a draft until fixes get in so that we have minimal reviewer impact; currently blocked by #205.