Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ok packet represents eof #1153

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tz70s
Copy link

@tz70s tz70s commented Sep 5, 2020

Description

Minor fixes from #962, ensuring backward compatibility on legacy EOF format.

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

This change is Reviewable

@tz70s tz70s force-pushed the support-deprecated-eof-packet branch from 476b93a to ea32d9f Compare September 5, 2020 04:15
@tz70s tz70s force-pushed the support-deprecated-eof-packet branch from ea32d9f to 667a05a Compare September 5, 2020 05:13
if err = mc.readUntilEOF(); err != nil {
return nil, err
}
}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems MySQL behavior isn't consistent to the documentation here: https://dev.mysql.com/doc/internals/en/com-stmt-prepare-response.html

However, Maria DB follows this specification.

IMO this feature should be held until there's a clear solution to be compatible with supported vendors.

Copy link
Contributor

@shiyuhang0 shiyuhang0 Nov 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I continue your excellent work? Does this problem be solved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants