Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean database cache from clear cache command #18119

Open
wants to merge 2 commits into
base: 10.0/bugfixes
Choose a base branch
from

Conversation

trasher
Copy link
Contributor

@trasher trasher commented Oct 22, 2024

Description

Clean database cache from clear cache command

Copy link
Member

@cedric-anne cedric-anne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I do not think we should consider that clearing the ancestors_cache/sons_cache is a normal cache clearing operation, for 2 distinct reasons.

  1. This cache contains only a list of IDs, so its contents is not supposed to changed and so there is not reason for it to become stale if the application invalidates/recompute it when it is required.

  2. This cache is used, for entities, to determine what can or cannot be seen by users, and therefore it must never be stale. If it cannot be stale, then there is no reason to invalidate it.

If we know that a specific operation can result in an invalid value, then we have to fix it, as we do in #17012.

If we consider that we had in the past some bugs that can explain that the value of these fields is corrupted (for instance #17012), then maybe the solution is to invalidate them once in the 10.0.16 -> 10.0.17 update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants