Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump tinymce from 7.3.0 to 7.4.1 #18093

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 17, 2024

Bumps tinymce from 7.3.0 to 7.4.1.

Changelog

Sourced from tinymce's changelog.

7.4.1 - 2024-10-10

Fixed

  • Invalid HTML elements within SVG elements were not removed. #TINY-11332

7.4.0 - 2024-10-09

Added

  • New context property for all ui components. This allows buttons and menu items to be enabled or disabled based on whether their context matches a given predicate; status updates are checked on init, NodeChange, and SwitchMode events. #TINY-11211
  • Tree component now allows the addition of a custom icon. #TINY-11131
  • Added focus function to view button api. #TINY-11122
  • New option allow_mathml_annotation_encodings to opt-in to keep math annotations with specific encodings. #TINY-11166
  • Added global color-active LESS variable for use in editor skins. #TINY-11266

Improved

  • In read-only mode the editor now allows normal cursor movement and block element selection, including video playback. #TINY-11264
  • Pasting a table now places the cursor after the table instead of into the last cell. #TINY-11082
  • Dialog list dropdown menus now close when the browser window resizes. #TINY-11123

Fixed

  • Mouse hover on partially visible dialog collection elements no longer scrolls. #TINY-9915
  • Caret would unexpectedly shift to the non-editable table row above when pressing Enter. #TINY-11077
  • Deleting a selection in a list element would sometimes prevent the input event from being dispatched. #TINY-11100
  • Placing the cursor after a table with a br after it would misplace added newlines before the table instead of after. #TINY-11110
  • Sidebar could not be toggled until the skin was loaded. #TINY-11155
  • The image dialog lost focus after closing an image upload error alert. #TINY-11159
  • Copying tables to the clipboard did not correctly separate cells and rows for the "text/plain" MIME type. #TINY-10847
  • The editor resize handle was incorrectly rendered when all components were removed from the status bar. #TINY-11257
Commits
  • b35f0fa TINY-11379: Changelog
  • 44f3a80 TINY-11332: Update dependencies (#9909)
  • 49ce762 TINY-11024: Bump version
  • 7e3b052 TINY-11024: Changelog for release (#9912)
  • 282d751 TINY-11024: Fix test failures for CopyAndPasteTest.ts (#9903)
  • 3080f8a TINY-11326: Disable restore last draft button in readonly mode (#9891)
  • 7db173c EPIC-114: Improve readonly mode and context for UI components (#9864)
  • 03b09d9 TINY-11266: move comments styles to oxide and adjust to skins (#9878)
  • 1ee9ed7 TINY-10847: Fix clipboard text content when copying tables (#9860)
  • 2916d1c TINY-11166: Fixed issue with editor config option (#9870)
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Oct 17, 2024
@cedric-anne
Copy link
Member

@dependabot rebase

Bumps [tinymce](https://github.com/tinymce/tinymce/tree/HEAD/modules/tinymce) from 7.3.0 to 7.4.1.
- [Changelog](https://github.com/tinymce/tinymce/blob/main/modules/tinymce/CHANGELOG.md)
- [Commits](https://github.com/tinymce/tinymce/commits/7.4.1/modules/tinymce)

---
updated-dependencies:
- dependency-name: tinymce
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/main/tinymce-7.4.1 branch from 9f0f2f4 to 012e266 Compare October 17, 2024 15:13
Copy link

sonarcloud bot commented Oct 17, 2024

@cedric-anne
Copy link
Member

@AdrienClairembault @ccailly The same e2e test failed multiple times. Could you check if the inyMCE update broke something ?

@AdrienClairembault
Copy link
Contributor

Seems like a regression on TinyMCE.

After the update, TinyMCE no longer set the editor body as contenteditable=false when we are in "readonly" mode:
image

It stills prevents text from being typed (probably by some JS logic ?) but this it make our tests fails because we explicitly check that content editable is false:

image

I guess we can try to type something and check nothing was added but it means the test will break if this behavior is fixed on tinymce in another release (as cypress will throw an error if we try to type into something with contenteditable=false, which is why the current code look directly for the attribute).

@cedric-anne
Copy link
Member

@AdrienClairembault

Could you open an issue on TinyMCE side ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants