fix notcontains search option operator

[btry]

SQL requests are wrong when using a search criteria with the operator notcontains.

It seems there is no unit tests for this, then I added them.

To reproduce

Need to find a search option having datatype = number without min nor max boundaries. Printer current count of page is an easy to test candidate.

Checklist before requesting a review

Please delete options that are not relevant.

• I have read the CONTRIBUTING document.
• I have performed a self-review of my code.
• I have added tests that prove my fix is effective or that my feature works.
• This change requires a documentation update.

Description

The variable $nott is used later in Search::addWhere() leading to a double negation. I de-factorized the code to fix the issue to stick in the same design as equals / notequals operators implementation.

Screenshots (if appropriate):

[btry]

This line is inverted compared to "contains" counterpart a few lines below

[btry]

reverted when we reach
https://github.com/glpi-project/glpi/blob/10.0/bugfixes/src/Search.php#L5405

[trasher]

Search has always been opaque to my eyes, but added test seems OK.

[cedric-anne]

Instead of duplicating the whole case code, maybe it was possible to just adapt a few lines.

For instance:

if ($searchtype === 'contains') {
    $subquery_operator = $nott ? "NOT IN" : "IN";
} else {
    $subquery_operator = $nott ? "IN" : "NOT IN";
}

and

$SEARCH = self::makeTextSearch($val, $searchtype === 'contains' ? $nott : !$nott);

[btry]

@cedric-anne

Yes, it would make sense. But I found there is a real mess with contains / notcontains on one hand and equals / not equals in the other hand. For numeric search options one or the other pair is used in function of the column being a ID or FK.
There are also many negations using $nott in case {...} structures which test table and column.

So I adopted the less risky solution, by reproducing the code pattern matching equals / not equals (which as far as I know is bug free).

[sonarcloud]

Quality Gate failed

Failed conditions
69.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud