Skip to content

Commit

Permalink
Log #StandWithUkraine to stderr
Browse files Browse the repository at this point in the history
  • Loading branch information
glebm committed Mar 22, 2022
1 parent d9b30e9 commit 7d50880
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions lib/i18n/tasks/command/commander.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ def initialize(i18n)
end

def run(name, opts = {})
log_stderr "#{Rainbow('#StandWith').bg(:blue)}#{Rainbow('Ukraine').bg(:yellow)}"
name = name.to_sym
public_name = name.to_s.tr '_', '-'
log_verbose "task: #{public_name}(#{opts.map { |k, v| "#{k}: #{v.inspect}" } * ', '})"
Expand Down

6 comments on commit 7d50880

@kyrofa
Copy link

@kyrofa kyrofa commented on 7d50880 Apr 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When text jumps off my terminal, I expect it to be an error. I have a small heart attack every time I run i18n-tasks now. Any chance you could add the ability to disable this?

@glebm
Copy link
Owner Author

@glebm glebm commented on 7d50880 Apr 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want every Ruby developer in Russia to see this, so I won't add an easy way to disable this.
This'll be removed soon enough when the war is over.

@swiknaba
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Software should stay neutral, and your personal opinions have nothing to do in my console log (and even less in the console logs of production applications - we have to explain/justify this now to superiors). Luckily this message is just one line and it seems not malicious. But where does it end? https://www.bleepingcomputer.com/news/security/dev-corrupts-npm-libs-colors-and-faker-breaking-thousands-of-apps/

@glebm
Copy link
Owner Author

@glebm glebm commented on 7d50880 Apr 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my software, don't tell me what to do.

@davidwessman
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swiknaba write your own library and do what you want. Software is written by people so software is not neutral. I stand with @glebm in this message.

@morbakh
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swiknaba you can fix it locally with this line for greater good, and let them stand where ever they want ;)

log_stderr "#{Rainbow('Liberte').bg(:white)}#{Rainbow('Egalite').bg(:blue)}#{Rainbow('Fraternite').bg(:red)}"

Please sign in to comment.