Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GDShader #7071

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add GDShader #7071

wants to merge 2 commits into from

Conversation

FireCatMagic
Copy link

@FireCatMagic FireCatMagic commented Oct 1, 2024

Description

Adds support for GDShader / Godot Shading Language. Will close the issue I made for it: #7067
GDShader is the shading language used for Godot Engine https://godotengine.org/
It is very similar to GLSL https://docs.godotengine.org/en/stable/tutorials/shaders/shader_reference/shading_language.html

This language has been known by the community as both GDShader and Godot Shading Language, as it lacked a true name. This problem was solved and it is officially being known as GDShader. (see godotengine/godot-proposals#10784)

Checklist:

@FireCatMagic FireCatMagic requested a review from a team as a code owner October 1, 2024 23:54
@FireCatMagic FireCatMagic changed the title Added GDShader Add GDShader Oct 1, 2024
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't accept an unlicensed grammar. All grammars must have a licence and it must be one of these to be accepted:

- apache-2.0
- bsd-2-clause
- bsd-3-clause
- cc0-1.0
- isc
- mit
- mpl-2.0
- ncsa
- permissive
- unlicense
- wtfpl
- zlib

@FireCatMagic
Copy link
Author

Ok, I removed gdshader-lsp

https://github.com/godotengine/godot-vscode-plugin Also supports GDShader (and GDScript) and has the MIT license - but it seems like this grammar is already included in the project, so I can't add it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants