Clean

giongto35 · Mar 2, 2024 · cdbb5e9 · cdbb5e9
1 parent 92e5967
commit cdbb5e9
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 20 deletions.
diff --git a/web/index.html b/web/index.html
@@ -131,12 +131,12 @@ <h1>Options</h1>
 <script src="js/room.js?v=3"></script>
 <script src="js/network/ajax.js?v=3"></script>
 <script src="js/network/socket.js?v=4"></script>
-<script src="js/network/webrtc.js?v=3"></script>
+<script src="js/network/webrtc.js?v=4"></script>
 <script src="js/recording.js?v=1"></script>
 <script src="js/api/api.js?v=3"></script>
 <script src="js/workerManager.js?v=1"></script>
 <script src="js/stats/stats.js?v=1"></script>
-<script src="js/controller.js?v=8"></script>
+<script src="js/controller.js?v=9"></script>
 <script src="js/input/keyboard.js?v=6"></script>
 <script src="js/input/touch.js?v=3"></script>
 <script src="js/input/joystick.js?v=3"></script>

diff --git a/web/js/controller.js b/web/js/controller.js
@@ -126,12 +126,6 @@
 
         stream.play()
 
-        // TODO get current game from the URL and not from the list?
-        // if we are opening a share link it will send the default game name to the server
-        // currently it's a game with the index 1
-        // on the server this game is ignored and the actual game will be extracted from the share link
-        // so there's no point in doing this and this' really confusing
-
         api.game.start(
             gameList.selected,
             room.getId(),
@@ -276,15 +270,15 @@
 
     const handleRecordingStatus = (data) => {
         if (data === 'ok') {
-            message.show(`Recording ${recording.isActive() ? 'on' : 'off'}`, true)
+            message.show(`Recording ${recording.isActive() ? 'on' : 'off'}`)
             if (recording.isActive()) {
                 recording.setIndicator(true)
             }
         } else {
             message.show(`Recording failed ):`)
             recording.setIndicator(false)
         }
-        console.log("recording is ", recording.isActive())
+        log.debug("recording is ", recording.isActive())
     }
 
     const _default = {

diff --git a/web/js/network/webrtc.js b/web/js/network/webrtc.js
@@ -146,7 +146,6 @@ const webrtc = (() => {
             event.pub(WEBRTC_SDP_ANSWER, {sdp: answer});
             media.srcObject = mediaStream;
         },
-        // setMessageHandler: (handler) => onMessage = handler,
         addCandidate: (data) => {
             if (data === '') {
                 event.pub(WEBRTC_ICE_CANDIDATES_FLUSH);
@@ -166,15 +165,6 @@ const webrtc = (() => {
             });
             isFlushing = false;
         },
-        // message: (mess = '') => {
-        //     try {
-        //         inputChannel.send(mess)
-        //         return true
-        //     } catch (error) {
-        //         log.error('[rtc] input channel broken ' + error)
-        //         return false
-        //     }
-        // },
         input: (data) => dataChannel.send(data),
         isConnected: () => connected,
         isInputReady: () => inputReady,