Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scala 3.4.2 #23

Merged
merged 1 commit into from
May 24, 2024
Merged

Add Scala 3.4.2 #23

merged 1 commit into from
May 24, 2024

Conversation

BardurArantsson
Copy link
Contributor

@BardurArantsson BardurArantsson commented May 24, 2024

Add Scala 3.4.2.

The CI stuff was done entirely via pattern matching on my part. Do let me know if I did something wrong :)

@ghik
Copy link
Owner

ghik commented May 24, 2024

Hi @BardurArantsson, thanks for the PR. CI files should be regenerated with sbt githubWorkflowGenerate. See https://github.com/ghik/zerowaste?tab=readme-ov-file#how-to-submit-a-pr-with-a-new-scala-version

@BardurArantsson
Copy link
Contributor Author

At the top of the README no less... Sigh, I need to learn to pay attention to docs :)

I've pushed a fixed version.

@ghik ghik merged commit 16019d7 into ghik:main May 24, 2024
18 checks passed
@BardurArantsson BardurArantsson deleted the scala-3.4.2 branch May 24, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants