Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for Scala 3.3.3 and 2.12.19 #19

Closed
wants to merge 4 commits into from
Closed

Update for Scala 3.3.3 and 2.12.19 #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f1e1d6f
Update for Scala 3.3.3 and 3.4.0
mtomko Feb 29, 2024
9d57831
Update list of scala versions in README
mtomko Feb 29, 2024
106d2fa
Add 2.12.18 and 2.12.19
mtomko Feb 29, 2024
bfec17a
Replace missing versions
mtomko Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 21 additions & 10 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ jobs:
scala:
- 3.4.1-RC1
- 3.4.0
- 3.3.3
- 3.3.2
- 3.3.1
- 3.3.1-RC7
Expand All @@ -41,9 +42,9 @@ jobs:
- 2.13.10
- 2.13.11
- 2.13.12
- 2.13.13
- 2.12.17
- 2.12.18
- 2.12.19
java: [temurin@17]
runs-on: ${{ matrix.os }}
steps:
Expand Down Expand Up @@ -141,6 +142,16 @@ jobs:
tar xf targets.tar
rm targets.tar

- name: Download target directories (3.3.3)
uses: actions/download-artifact@v2
with:
name: target-${{ matrix.os }}-3.3.3-${{ matrix.java }}

- name: Inflate target directories (3.3.3)
run: |
tar xf targets.tar
rm targets.tar

- name: Download target directories (3.3.2)
uses: actions/download-artifact@v2
with:
Expand Down Expand Up @@ -291,32 +302,32 @@ jobs:
tar xf targets.tar
rm targets.tar

- name: Download target directories (2.13.13)
- name: Download target directories (2.12.17)
uses: actions/download-artifact@v2
with:
name: target-${{ matrix.os }}-2.13.13-${{ matrix.java }}
name: target-${{ matrix.os }}-2.12.17-${{ matrix.java }}

- name: Inflate target directories (2.13.13)
- name: Inflate target directories (2.12.17)
run: |
tar xf targets.tar
rm targets.tar

- name: Download target directories (2.12.17)
- name: Download target directories (2.12.18)
uses: actions/download-artifact@v2
with:
name: target-${{ matrix.os }}-2.12.17-${{ matrix.java }}
name: target-${{ matrix.os }}-2.12.18-${{ matrix.java }}

- name: Inflate target directories (2.12.17)
- name: Inflate target directories (2.12.18)
run: |
tar xf targets.tar
rm targets.tar

- name: Download target directories (2.12.18)
- name: Download target directories (2.12.19)
uses: actions/download-artifact@v2
with:
name: target-${{ matrix.os }}-2.12.18-${{ matrix.java }}
name: target-${{ matrix.os }}-2.12.19-${{ matrix.java }}

- name: Inflate target directories (2.12.18)
- name: Inflate target directories (2.12.19)
run: |
tar xf targets.tar
rm targets.tar
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Scala compiler plugin to detect unused expressions (non-`Unit`).

Zerowaste is currently available for Scala 2.12.17+, 2.13.10+ and 3.2.1+
Zerowaste is currently available for Scala 2.12.17+, 2.13.10+, 3.2.1+, 3.3.0+, and 3.4.0+

Compiler plugins must be cross-built for every minor and patch version of Scala. If `zerowaste` is not available for a Scala version that you want to use (most likely some freshly released one), please file an issue or submit a PR.

Expand All @@ -28,7 +28,7 @@ val number = {
}
```

This is an easy mistake and it can lead to tricky bugs, such as when an important IO action is unintentionally discarded.
This is an easy mistake and it can lead to tricky bugs, such as when an important IO action is unintentionally discarded.
The Scala compiler cannot detect this issue as Scala is not a purely functional language and cannot assume all expressions are pure.

This plugin addresses this problem by reporting a warning for every discarded expression whose type is different than `Unit`.
Expand Down
6 changes: 3 additions & 3 deletions build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ inThisBuild(Seq(
scalaVersion := crossScalaVersions.value.head,
crossScalaVersions := Seq(
"3.4.1-RC1", "3.4.0",
"3.3.2", "3.3.1", "3.3.1-RC7", "3.3.1-RC6", "3.3.1-RC5", "3.3.1-RC4", "3.3.1-RC3", "3.3.1-RC2", "3.3.1-RC1", "3.3.0",
"3.3.3", "3.3.2", "3.3.1", "3.3.1-RC7", "3.3.1-RC6", "3.3.1-RC5", "3.3.1-RC4", "3.3.1-RC3", "3.3.1-RC2", "3.3.1-RC1", "3.3.0",
"3.2.2", "3.2.1",
"2.13.10", "2.13.11", "2.13.12", "2.13.13",
"2.12.17", "2.12.18"
"2.13.10", "2.13.11", "2.13.12",
"2.12.17", "2.12.18", "2.12.19"
),

githubWorkflowTargetTags ++= Seq("v*"),
Expand Down
Loading