Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverted gradle cache on github actions #2836

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Conversation

stefanosiano
Copy link
Member

📜 Description

reverted gradle cache on gha, as it seems to slow down tests
#skip-changelog

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@stefanosiano stefanosiano marked this pull request as ready for review July 11, 2023 18:24
@github-actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 282.00 ms 333.81 ms 51.81 ms
Size 1.72 MiB 2.29 MiB 575.24 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8820c5c 330.60 ms 416.86 ms 86.26 ms
9246ed4 281.79 ms 352.08 ms 70.29 ms
496bdfd 301.22 ms 343.96 ms 42.73 ms
f274c79 334.86 ms 348.54 ms 13.68 ms
9246ed4 275.63 ms 321.31 ms 45.69 ms
f274c79 313.96 ms 355.96 ms 42.00 ms
c03a05e 390.40 ms 419.35 ms 28.94 ms
0310da5 381.20 ms 404.50 ms 23.30 ms
496bdfd 272.86 ms 407.33 ms 134.48 ms
dc67004 273.86 ms 346.37 ms 72.51 ms

App size

Revision Plain With Sentry Diff
8820c5c 1.72 MiB 2.28 MiB 571.82 KiB
9246ed4 1.72 MiB 2.28 MiB 572.22 KiB
496bdfd 1.72 MiB 2.28 MiB 571.82 KiB
f274c79 1.72 MiB 2.29 MiB 575.01 KiB
9246ed4 1.72 MiB 2.28 MiB 572.22 KiB
f274c79 1.72 MiB 2.29 MiB 575.01 KiB
c03a05e 1.72 MiB 2.29 MiB 574.43 KiB
0310da5 1.72 MiB 2.28 MiB 573.45 KiB
496bdfd 1.72 MiB 2.28 MiB 571.82 KiB
dc67004 1.72 MiB 2.28 MiB 573.45 KiB

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (caf50ec) 81.29% compared to head (6cf5cca) 81.29%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2836   +/-   ##
=========================================
  Coverage     81.29%   81.29%           
  Complexity     4565     4565           
=========================================
  Files           351      351           
  Lines         16874    16874           
  Branches       2272     2272           
=========================================
  Hits          13717    13717           
  Misses         2216     2216           
  Partials        941      941           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stefanosiano stefanosiano merged commit 4bac687 into main Jul 12, 2023
22 checks passed
@stefanosiano stefanosiano deleted the fix/revert-gradle-cache branch July 12, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants