-
-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Use compute to offload heavy work from the main thread #707
Conversation
`Instructions and example for changelog`$
To the changelog entry, please add a link to this PR (consider a more descriptive message):` - Use compute to offload heavy work from the main thread(#707)
|
Does it work for file attachments? |
getting the error:
|
Didn't test it yet, not working even for Events right now. |
Codecov Report
@@ Coverage Diff @@
## main #707 +/- ##
==========================================
+ Coverage 90.67% 90.96% +0.28%
==========================================
Files 104 8 -96
Lines 3326 155 -3171
==========================================
- Hits 3016 141 -2875
+ Misses 310 14 -296 Continue to review full report at Codecov.
|
_convert, | ||
_CaptureEnvelopeData(envelope, _options), | ||
debugLabel: 'captureEnvelope $eventIdLabel', | ||
); | ||
try { | ||
await _channel.invokeMethod<void>('captureEnvelope', args); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
args
previously was an array
await _channel.invokeMethod<void>('captureEnvelope', args); | |
await _channel.invokeMethod<void>('captureEnvelope', [args]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a comment which tells you which type should get passed. Probably also a test which asserts that 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's indeed another problem, but the error is actually with the compute
flag, See #707 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, at least the tests are now passing.
📜 Description
Enhancement: Use compute to offload heavy work from the main thread
💡 Motivation and Context
Closes #536
💚 How did you test it?
📝 Checklist
🔮 Next steps