-
-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sample app #2358
Merged
Merged
fix: sample app #2358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buenaflor
requested review from
krystofwoldrich,
stefanosiano and
martinhaintz
as code owners
October 15, 2024 11:17
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2358 +/- ##
==========================================
+ Coverage 84.82% 85.02% +0.19%
==========================================
Files 253 79 -174
Lines 9062 2791 -6271
==========================================
- Hits 7687 2373 -5314
+ Misses 1375 418 -957 ☔ View full report in Codecov by Sentry. |
6 tasks
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6078ddc | 385.72 ms | 463.61 ms | 77.89 ms |
e6b16cd | 523.24 ms | 594.77 ms | 71.53 ms |
c3e6c82 | 392.63 ms | 440.76 ms | 48.12 ms |
f83bc1d | 319.32 ms | 418.48 ms | 99.16 ms |
d8519f9 | 352.83 ms | 420.46 ms | 67.62 ms |
905bf99 | 459.73 ms | 505.26 ms | 45.53 ms |
acbd5d3 | 367.53 ms | 428.76 ms | 61.23 ms |
9f9dd52 | 366.75 ms | 443.26 ms | 76.51 ms |
3e33891 | 313.60 ms | 379.51 ms | 65.91 ms |
84c28cd | 415.11 ms | 549.44 ms | 134.33 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6078ddc | 6.34 MiB | 7.29 MiB | 967.80 KiB |
e6b16cd | 6.35 MiB | 7.33 MiB | 1005.63 KiB |
c3e6c82 | 6.33 MiB | 7.26 MiB | 950.19 KiB |
f83bc1d | 6.27 MiB | 7.20 MiB | 956.51 KiB |
d8519f9 | 6.33 MiB | 7.26 MiB | 946.13 KiB |
905bf99 | 6.49 MiB | 7.56 MiB | 1.07 MiB |
acbd5d3 | 6.35 MiB | 7.35 MiB | 1017.84 KiB |
9f9dd52 | 6.35 MiB | 7.35 MiB | 1019.02 KiB |
3e33891 | 6.16 MiB | 7.14 MiB | 1007.46 KiB |
84c28cd | 6.49 MiB | 7.56 MiB | 1.07 MiB |
Previous results on branch: fix/sample-app
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3639f8c | 508.09 ms | 572.73 ms | 64.64 ms |
1a35715 | 466.37 ms | 507.08 ms | 40.71 ms |
24d1fcc | 460.00 ms | 504.98 ms | 44.98 ms |
3900e3a | 511.40 ms | 600.52 ms | 89.12 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3639f8c | 6.49 MiB | 7.56 MiB | 1.07 MiB |
1a35715 | 6.49 MiB | 7.57 MiB | 1.08 MiB |
24d1fcc | 6.49 MiB | 7.56 MiB | 1.07 MiB |
3900e3a | 6.49 MiB | 7.56 MiB | 1.07 MiB |
buenaflor
commented
Oct 15, 2024
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
49a149b | 1296.47 ms | 1320.20 ms | 23.73 ms |
89ea268 | 1252.33 ms | 1253.58 ms | 1.26 ms |
8e133ad | 1268.19 ms | 1277.37 ms | 9.18 ms |
5603ab2 | 1268.47 ms | 1280.73 ms | 12.26 ms |
5112c69 | 1272.76 ms | 1293.37 ms | 20.61 ms |
4ad2751 | 1247.67 ms | 1249.20 ms | 1.53 ms |
21845e2 | 1279.37 ms | 1298.81 ms | 19.45 ms |
c9d3212 | 1231.84 ms | 1237.40 ms | 5.57 ms |
d4120ac | 1260.61 ms | 1274.09 ms | 13.47 ms |
7faee57 | 1232.65 ms | 1246.10 ms | 13.45 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
49a149b | 8.15 MiB | 9.12 MiB | 986.26 KiB |
89ea268 | 8.09 MiB | 9.16 MiB | 1.06 MiB |
8e133ad | 8.10 MiB | 9.16 MiB | 1.07 MiB |
5603ab2 | 8.15 MiB | 9.12 MiB | 990.57 KiB |
5112c69 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
4ad2751 | 8.29 MiB | 9.39 MiB | 1.10 MiB |
21845e2 | 8.15 MiB | 9.12 MiB | 991.34 KiB |
c9d3212 | 8.29 MiB | 9.39 MiB | 1.10 MiB |
d4120ac | 8.28 MiB | 9.34 MiB | 1.06 MiB |
7faee57 | 8.33 MiB | 9.64 MiB | 1.31 MiB |
Previous results on branch: fix/sample-app
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3900e3a | 1250.58 ms | 1276.59 ms | 26.00 ms |
24d1fcc | 1245.82 ms | 1273.21 ms | 27.39 ms |
3639f8c | 1244.84 ms | 1264.90 ms | 20.06 ms |
1a35715 | 1252.85 ms | 1282.24 ms | 29.39 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3900e3a | 8.38 MiB | 9.74 MiB | 1.36 MiB |
24d1fcc | 8.38 MiB | 9.74 MiB | 1.36 MiB |
3639f8c | 8.38 MiB | 9.74 MiB | 1.36 MiB |
1a35715 | 8.38 MiB | 9.75 MiB | 1.37 MiB |
@denrase can you approve pls |
stefanosiano
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
Closes #2261