-
-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky iOS integration test #1524
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e4d0c17
use xcrun directly instead of subosito/flutter-action
denrase 7ba3cd1
close sentry in tearDown, don’t call pumpandsettle
denrase a3e1895
bump macos version and simulator
denrase a4e3c5b
downgrade runtime
denrase 08505e6
Merge branch 'main' into fix/flaky-ios-tests
denrase c0ae3c5
enable android test
denrase e40f399
Merge branch 'main' into fix/flaky-ios-tests
denrase 7f69c79
Merge branch 'main' into fix/flaky-ios-tests
marandaneto c6f1a14
Merge branch 'main' into fix/flaky-ios-tests
marandaneto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ import 'package:sentry_flutter_example/main.dart'; | |
void main() { | ||
TestWidgetsFlutterBinding.ensureInitialized(); | ||
|
||
setUp(() async { | ||
tearDown(() async { | ||
await Sentry.close(); | ||
}); | ||
|
||
|
@@ -18,7 +18,6 @@ void main() { | |
bundle: SentryAssetBundle(enableStructuredDataTracing: true), | ||
child: const MyApp(), | ||
))); | ||
await tester.pumpAndSettle(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Isn't that needed anymore? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does not make a difference in the tests as far as i could tell. |
||
}, 'https://abc@def.ingest.sentry.io/1234567'); | ||
} | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can apply those changes after merged here #1543
This helps with speeding up and flakiness.