Skip to content

Commit

Permalink
feat: windows native error & obfuscation support (#2286)
Browse files Browse the repository at this point in the history
* chore: update windows code based on latest flutter template with plugin_ffi

* feat: add sentry-native library to the windows build

* add sentry-native bindings

* basic tests

* more native binding functions

* improve native tests

* more native binding calls

* load debug image list

* add native feature support flags

* clean

* update native crash example

* post-merge fixup

* example: allways show console in the windows sample app

* fix: windows build with crashpad

* update test script

* tmp

* tmp

* tmp

* remove cmake_minimum_required

* windows native obfuscated stack trace support

* move native debug image resolution to sentry_native.dart

* fix native test setup

* further improve native test build

* update debug id conversion code

* fix native init test

* test fixes

* cleanup

* improve native test

* ensure crashpad_wer is distributed

* post-merge failing test fixes

* move stacktrace parsing back to stacktrace factory

* fix debug image integration and tests

* tmp: use sentry.init in the flutter example

* fixup dart deps

* comment fix

* rename: SentryStackTraceFactory create() to parse()

* linter isssues

* analyzer issue

* fix tests on web

* fixup code coverage test

* chore: update stacktrace tests

* fix missing deps

* formatting

* add missing override annotations

* merge sentry-native debug image creation to dart

* analyzer issues

* disable analysis on generated code

* chore: update changelog

* analyzer issues

* fix tests

* Revert "tmp: use sentry.init in the flutter example"

This reverts commit 1c7b63d.

* test: fix flutter test

* fix int.toNativeValue() range

* comments

* Update CHANGELOG.md
  • Loading branch information
vaind authored Oct 10, 2024
1 parent 77b8ba7 commit 20926fc
Show file tree
Hide file tree
Showing 57 changed files with 2,496 additions and 796 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/flutter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -103,15 +103,16 @@ jobs:
with:
name: sentry_flutter
file: ./flutter/coverage/lcov.info
functionalities: "search" # remove after https://github.com/codecov/codecov-action/issues/600
functionalities: 'search' # remove after https://github.com/codecov/codecov-action/issues/600
token: ${{ secrets.CODECOV_TOKEN }}

- uses: VeryGoodOpenSource/very_good_coverage@c953fca3e24a915e111cc6f55f03f756dcb3964c # pin@v3.0.0
if: matrix.sdk == 'stable' && matrix.target == 'linux'
with:
path: './flutter/coverage/lcov.info'
min_coverage: 90
exclude: 'lib/src/native/cocoa/binding.dart'
# 'native/c' for now because we run coverage on Linux where these are not tested yet.
exclude: 'lib/src/native/cocoa/binding.dart lib/src/native/c/*'

- name: Build ${{ matrix.target }}
working-directory: flutter/example
Expand Down
10 changes: 9 additions & 1 deletion .github/workflows/update-deps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Update Dependencies
on:
# Run every day.
schedule:
- cron: "0 3 * * *"
- cron: '0 3 * * *'
# And on on every PR merge so we get the updated dependencies ASAP, and to make sure the changelog doesn't conflict.
push:
branches:
Expand All @@ -27,6 +27,14 @@ jobs:
secrets:
api-token: ${{ secrets.CI_DEPLOY_KEY }}

native:
uses: getsentry/github-workflows/.github/workflows/updater.yml@v2
with:
path: flutter/scripts/update-native.sh
name: Native SDK
secrets:
api-token: ${{ secrets.CI_DEPLOY_KEY }}

metrics-flutter:
uses: getsentry/github-workflows/.github/workflows/updater.yml@v2
with:
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

- Emit `transaction.data` inside `contexts.trace.data` ([#2284](https://github.com/getsentry/sentry-dart/pull/2284))
- Blocking app starts if "appLaunchedInForeground" is false. (Android only) ([#2291](https://github.com/getsentry/sentry-dart/pull/2291))
- Windows native error & obfuscation support ([#2286](https://github.com/getsentry/sentry-dart/pull/2286))

### Enhancements

Expand Down
195 changes: 0 additions & 195 deletions dart/lib/src/debug_image_extractor.dart

This file was deleted.

Loading

0 comments on commit 20926fc

Please sign in to comment.