Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schema): Add view_names to AppContext #2344

Merged
merged 12 commits into from
Sep 4, 2023

Conversation

denrase
Copy link
Contributor

@denrase denrase commented Jul 24, 2023

Adds the view_names property to AppContext, so clients can send which screen (or multiple screens) are visible to the user during an event.

Relates to getsentry/sentry-dart#1545

@denrase denrase changed the title Add view_name to AppContext Add view_names to AppContext Jul 31, 2023
@marandaneto
Copy link
Contributor

@denrase you can mark it as ready for review, maybe just the snapshots need to be fixed.

@marandaneto marandaneto marked this pull request as ready for review August 8, 2023 14:16
@marandaneto marandaneto requested a review from a team August 8, 2023 14:16
@marandaneto
Copy link
Contributor

@jjbayer @alek-sentry would you be able to review this for us? thanks.

Copy link
Contributor

@olksdr olksdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

you might want to add changelog entry in Unreleased section about the change or just skip the changelog altogether

Copy link
Contributor

@iker-barriocanal iker-barriocanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

As a side note, we use a specific commit message format at Sentry, defined here. Could we update the PR description?

@denrase denrase changed the title Add view_names to AppContext feat(app-context): Add view_names to AppContext Aug 22, 2023
@denrase
Copy link
Contributor Author

denrase commented Aug 22, 2023

@iker-barriocanal Updated the title and description. Guess these should be used in the (squash) commit message when merging the issue? Is this what you had in mind? Thank you!

@denrase denrase changed the title feat(app-context): Add view_names to AppContext feat(schema): Add view_names to AppContext Aug 22, 2023
@iker-barriocanal
Copy link
Contributor

@denrase yep, thanks for updating! Feel free to go ahead and merge

@denrase
Copy link
Contributor Author

denrase commented Sep 4, 2023

@iker-barriocanal I merged in the current main, could you be so kind and approve the workflows? ty 🙇

@denrase
Copy link
Contributor Author

denrase commented Sep 4, 2023

@iker-barriocanal Ok, think everything is in place and we can merge? Would you be so kind, as I don't have the permission on this repo. :)

@iker-barriocanal iker-barriocanal merged commit c5834bf into getsentry:master Sep 4, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants