-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(schema): Add view_names
to AppContext
#2344
feat(schema): Add view_names
to AppContext
#2344
Conversation
@denrase you can mark it as ready for review, maybe just the snapshots need to be fixed. |
@jjbayer @alek-sentry would you be able to review this for us? thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
you might want to add changelog entry in Unreleased
section about the change or just skip the changelog altogether
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
As a side note, we use a specific commit message format at Sentry, defined here. Could we update the PR description?
view_names
to AppContext
view_names
to AppContext
@iker-barriocanal Updated the title and description. Guess these should be used in the (squash) commit message when merging the issue? Is this what you had in mind? Thank you! |
view_names
to AppContext
view_names
to AppContext
@denrase yep, thanks for updating! Feel free to go ahead and merge |
# Conflicts: # CHANGELOG.md
@iker-barriocanal I merged in the current main, could you be so kind and approve the workflows? ty 🙇 |
@iker-barriocanal Ok, think everything is in place and we can merge? Would you be so kind, as I don't have the permission on this repo. :) |
Adds the
view_names
property toAppContext
, so clients can send which screen (or multiple screens) are visible to the user during an event.Relates to getsentry/sentry-dart#1545