Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New DarkSpook color scheme #68

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

New DarkSpook color scheme #68

wants to merge 4 commits into from

Conversation

hngts
Copy link

@hngts hngts commented Dec 20, 2023

DarkSpook color scheme based on InkPot color scheme.

DarkSpook color scheme based on **InkPot** color scheme.
@hngts
Copy link
Author

hngts commented Dec 21, 2023

I have left licence header from the original author on purpose. [theme_info] section points on me.
I hope that's ok.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if you could make a screenshot like described in https://github.com/geany/geany-themes/blob/master/ADDING-A-THEME.md#adding-a-screenshot.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind to replace the screenshot as described above?

string_4=#A1CDCA;;false;false
string_eol=#A1C1CD;;false;false
character=#A86027;;false;false
backticks=#008C39l;;false;false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Geany complains about the invalid color value:

Geany-INFO: 00:00:55.142: Bad color '#008C39l'
Geany-INFO: 00:00:55.145: selection style is set to invisible - ignoring!

Note also the selection style warning.

Copy link
Author

@hngts hngts Dec 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Geany complains about the invalid color value:

Ouch!
Thanks.

That 7th l character (not including # ) is actually ;, but my finger apparently slipped.
Will remove it.

Note also the selection style warning.

Yes, that I am aware of. Tried various combinations, it looks quite ok like this.

I noticed that the name of the file is dark-spook.conf, but Titled Name is DarkSpook.
Should I correct that as well ? From DarkSpook to Dark Spook into config or I leave as is ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Geany complains about the invalid color value:

Ouch! Thanks.

That 7th l character (not including # ) is actually ;, but my finger apparently slipped. Will remove it.

:)

Note also the selection style warning.

Yes, that I am aware of. Tried various combinations, it looks quite ok like this.

It would be nice if we could avoid the warning.

I noticed that the name of the file is dark-spook.conf, but Titled Name is DarkSpook. Should I correct that as well ? From DarkSpook to Dark Spook into config or I leave as is ?

I think this is OK, some other themes do this as well.

# Editor styles
#-------------------------------------------------------------------------------

selection=;#4e4e8f;false;false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
selection=;#4e4e8f;false;false
selection=;#4e4e8f;false;true

This eliminates the warning and makes selected text look much better as the background color is used.

See https://geany.org/manual/#styling-section-1 for reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants