Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vcpkg hash #3383

Merged
merged 1 commit into from
Apr 14, 2024
Merged

Conversation

talregev
Copy link
Contributor

@talregev talregev commented Apr 13, 2024

Fix #3382
Change to windows-2022
Update vcpkg hash
Update latest cmake

@talregev
Copy link
Contributor Author

On the ci, on freeimage configure:
I get this error:

CMake Error at D:/a/gazebo-classic/gazebo-classic/vcpkg/installed/x64-windows-release/share/WebP/WebPConfig.cmake:15 (message):
  File or directory
  D:/a/gazebo-classic/gazebo-classic/vcpkg/installed/include referenced by
  variable WebP_INCLUDE_DIR does not exist !
Call Stack (most recent call first):
  D:/a/gazebo-classic/gazebo-classic/vcpkg/installed/x64-windows-release/share/WebP/WebPConfig.cmake:38 (set_and_check)
  D:/a/gazebo-classic/gazebo-classic/vcpkg/scripts/buildsystems/vcpkg.cmake:859 (_find_package)
  CMakeLists.txt:17 (find_package)

On my local windows, everything ok.

I will try again with the latest hash, and vs2022,
then I will send the logs to vcpkg to ask there.

@traversaro Can you look the logs too?
When it fail, it upload fail logs.

windows_logs_x64_d75efddcf3302cac721b3eb5237d913e64667b77.zip

@talregev talregev force-pushed the TalR/vcpkg_update_hash branch 2 times, most recently from d41bec1 to 637cf60 Compare April 13, 2024 18:09
@talregev
Copy link
Contributor Author

It was old cmake version problem. It a bug on vcpkg.
If there is an old cmake, it not check the version, and not download the correct cmake version.

Update latest cmake
@traversaro
Copy link
Collaborator

Thanks! If the issue was with CMake 3.29.1 the change was reverted in CMake 3.29.2, so we can also wait the GHA image to get the latest CMake. Just a curiosity, why the change from windows-latest to windows-2022? To increase reproducibility?

@traversaro
Copy link
Collaborator

Anyhow, the vcpkg CI is happy, so let's merge this.

@traversaro traversaro merged commit 291ab64 into gazebosim:gazebo11 Apr 14, 2024
8 of 10 checks passed
@talregev talregev deleted the TalR/vcpkg_update_hash branch April 14, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows vcpkg job failing (April 2024)
2 participants