Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port sensor update rate fix #3353

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Port sensor update rate fix #3353

merged 2 commits into from
Nov 8, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Oct 12, 2023

🦟 Bug fix

Summary

cherry-picked commit from #2863 to gazebo11

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@peci1
Copy link
Contributor

peci1 commented Oct 12, 2023

Thanks for the forward port. What about the missing mutex lock?

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
Copy link
Contributor Author

iche033 commented Oct 12, 2023

Thanks for the forward port. What about the missing mutex lock?

ah missed the note about mutex. Added. 82851d1

@traversaro
Copy link
Collaborator

@peci1 does the fix looks ready for merge to you? Thanks!

Copy link
Contributor

@peci1 peci1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, LGTM!

@traversaro
Copy link
Collaborator

Ok, I will leave some time for other people to comment, and then I will proceed to merge. Feel free to ping me if I forgot to merge.

@peci1
Copy link
Contributor

peci1 commented Nov 8, 2023

So, is 2 weeks a long enough incubation period? :)

@traversaro
Copy link
Collaborator

So, is 2 weeks a long enough incubation period? :)

Even less, thanks for the ping!

@traversaro traversaro merged commit 41b34e5 into gazebo11 Nov 8, 2023
8 of 10 checks passed
@traversaro traversaro deleted the sensor_rate_lockstep11 branch November 8, 2023 09:50
@EmmanuelMess
Copy link

Sorry to comment on an old PR, but I must ask. Was the IMU provided by "GazeboRosImu" tested? Do other IMU plugins (custom made by third parties, like hector's IMU) need retrofiting?

@traversaro
Copy link
Collaborator

Sorry to comment on an old PR, but I must ask. Was the IMU provided by "GazeboRosImu" tested? Do other IMU plugins (custom made by third parties, like hector's IMU) need retrofiting?

If you have a doubt on GazeboRosImu, I suggest to open a (new) issue in https://github.com/ros-simulation/gazebo_ros_pkgs . For other IMUs, I suggest to open a new issue in this. However, it increases the chances that somebody replies if you provide more context to your questions, for example: are you experiencing problems with GazeboRosImu? Why do you think that third parties IMU plugin need to be retrofitted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants