Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ff-ap-timer: Add ap-timer and web-ap-timer from FFHO #80

Merged
merged 3 commits into from
Jan 4, 2024

Conversation

maurerle
Copy link
Member

@maurerle maurerle commented Dec 21, 2023

This makes it possible to add these well-known packages without adding a special package source for these.

It also allows to further develop the package in the future and adjust to eventually needed changes.

The ffac-ap-timer package can turn the client_radio on and off, but does not touch mesh or private wifi configuration.
The ffac-web-ap-timer package makes it possible to configure the schedule in the config mode.

closes #37

@grische
Copy link
Contributor

grische commented Dec 21, 2023

@maurerle do you want to add this as ff- instead of ffac- as suggested recently in the chat? Or do you want to maintain this package in the future?

Copy link
Contributor

@grische grische left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally speaking, this version looks almost identical to the one we are already using with a few minor code improvements.

Where did you find that the original code was licensed under BSD 2?

@maurerle maurerle changed the title Add ap-timer and web-ap-timer from FFHO ff-ap-timer: Add ap-timer and web-ap-timer from FFHO Jan 3, 2024
@maurerle
Copy link
Member Author

maurerle commented Jan 3, 2024

I did split this into three commits:

  1. takes the old package
  2. renaming to ff- and add license from https://github.com/FreifunkHochstift/ffho-packages/blob/master/LICENSE - and remove old migration
  3. adjustments to pass luacheck

This can be merged from my side

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you also want to rename this file here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

pass luacheck
rename translation file
@maurerle
Copy link
Member Author

maurerle commented Jan 4, 2024

I tested this package on a 7520 and it works good:

image

In the web settings, only the daily option is exposed.

This script changes the uci value on a daily base and writes the changes to flash, then restarts the wifi using wifi twice a day too.
This might be considered when using this package, but from the long history of this package I did not hear of devices which were broken due to this.

@maurerle maurerle requested a review from grische January 4, 2024 10:08
Copy link
Contributor

@grische grische left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@maurerle maurerle merged commit 0f9f758 into freifunk-gluon:master Jan 4, 2024
2 checks passed
@maurerle maurerle deleted the add_ap_timer branch January 4, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ffho-ap-timer and ffho-web-ap-timer
2 participants