Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pytest-mysql from 2.5.0 to 3.0.0 #765

Merged
merged 2 commits into from
Jun 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Pipfile
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ black = "==24.4.0"
pytest = "==8.2.0"
pytest-cov = "==5.0.0"
mock = "==5.1.0"
pytest-mysql = "==2.5.0"
pytest-mysql = "==3.0.0"
pytest-postgresql = "==6.0.0"
pytest-pyramid = "==1.0.3"
tbump = "==6.11.0"
Expand Down
1 change: 1 addition & 0 deletions newsfragments/765.misc.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Adjust tests for updated pytest-mysql using pymysql instead of mysqlclient.
3 changes: 2 additions & 1 deletion tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,12 @@
"""Session for SQLAlchemy."""
from pyramid_fullauth.models import Base # pylint:disable=import-outside-toplevel

connection = ""
if request.param == "sqlite":
connection = "sqlite:///fullauth.sqlite"
elif request.param == "mysql":
request.getfixturevalue("mysql") # takes care of creating database
connection = "mysql+mysqldb://root:@127.0.0.1:3307/tests?charset=utf8"
connection = "mysql+pymysql://root:@127.0.0.1:3307/tests?charset=utf8"

Check warning on line 42 in tests/conftest.py

View check run for this annotation

Codecov / codecov/patch

tests/conftest.py#L42

Added line #L42 was not covered by tests
elif request.param == "postgresql":
request.getfixturevalue("postgresql") # takes care of creating database
connection = "postgresql+psycopg://postgres:@127.0.0.1:5433/tests"
Expand Down
Loading