-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
improve error handling and use json marshall better, add a small test…
… for sem ver
- Loading branch information
Showing
7 changed files
with
139 additions
and
63 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,43 @@ | ||
| package releases | ||
|
|
||
| import ( | ||
| "encoding/json" | ||
| "fmt" | ||
| ) | ||
|
|
||
| func GetLatestProviderRelease(provider string) (map[string]interface{}, error) { | ||
| return makeGetRequest(fmt.Sprintf("https://registry.terraform.io/v1/providers/%s", provider)) | ||
| type ProviderData struct { | ||
| Name string | ||
| Version string | ||
| } | ||
| type TerraformData struct { | ||
| Name string | ||
| Version string | ||
| } | ||
|
|
||
| func GetLatestProviderRelease(provider string) (*ProviderData, error) { | ||
| providerResponse, err := makeGetRequest(fmt.Sprintf("https://registry.terraform.io/v1/providers/%s", provider)) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| var providerData ProviderData | ||
| err = json.Unmarshal(providerResponse, &providerData) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| return &providerData, nil | ||
|
|
||
| } | ||
|
|
||
| func GetLatestTerraformRelease() (map[string]interface{}, error) { | ||
| return makeGetRequest("https://api.releases.hashicorp.com/v1/releases/terraform/latest") | ||
| func GetLatestTerraformRelease() (*TerraformData, error) { | ||
| terraformResponse, err := makeGetRequest("https://api.releases.hashicorp.com/v1/releases/terraform/latest") | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| var terraformData TerraformData | ||
| err = json.Unmarshal(terraformResponse, &terraformData) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| return &terraformData, nil | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| package tfmodule | ||
|
|
||
| import ( | ||
| "testing" | ||
| ) | ||
|
|
||
| func Test_truncatePatchVersion(t *testing.T) { | ||
| type args struct { | ||
| version string | ||
| } | ||
| tests := []struct { | ||
| name string | ||
| args args | ||
| want string | ||
| wantErr bool | ||
| }{ | ||
| { | ||
| name: "regular version", | ||
| args: args{version: "1.2.3"}, | ||
| want: "1.2", | ||
| wantErr: false, | ||
| }, | ||
| { | ||
| name: "minor only version", | ||
| args: args{version: "1.2"}, | ||
| want: "", | ||
| wantErr: true, | ||
| }, | ||
| { | ||
| name: "major only version", | ||
| args: args{version: "1"}, | ||
| want: "", | ||
| wantErr: true, | ||
| }, | ||
| { | ||
| name: "regular big", | ||
| args: args{version: "12.34.56"}, | ||
| want: "12.34", | ||
| wantErr: false, | ||
| }, | ||
| { | ||
| name: "bad version", | ||
| args: args{version: "02.34.56"}, | ||
| want: "", | ||
| wantErr: true, | ||
| }, | ||
| } | ||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| got, err := truncatePatchVersion(tt.args.version) | ||
| if (err != nil) != tt.wantErr { | ||
| t.Errorf("truncatePatchVersion() error = %v, wantErr %v", err, tt.wantErr) | ||
| return | ||
| } | ||
| if got != tt.want { | ||
| t.Errorf("truncatePatchVersion() = %v, want %v", got, tt.want) | ||
| } | ||
| }) | ||
| } | ||
| } |