Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add --quiet to chainindex validate-backfill + cleanups #12611

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Oct 17, 2024

Comes from working through what a cron job would look like to do this regularly

  • --quiet
  • non-zero exit code on failures
  • some cleanups targeting --help output

var chainIndexCmds = &cli.Command{
Name: "chainindex",
Usage: "Commands related to managing the chainindex",
HideHelpCommand: true,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately this hides subcommands from lotus-shed chainindex help output


The command validates the chain index entries for each epoch in the specified range, checking for missing or
inconsistent entries (i.e. the indexed data does not match the actual chain state). If '--backfill' is enabled
(which it is by default), it will attempt to backfill any missing entries using the 'ChainValidateIndex' API.

Parameters:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this because it duplicates what urfave/cli/v2 prints out below this text

@rvagg rvagg force-pushed the rvagg/lotus-shed/chainindex branch from 48bce27 to 7ed9129 Compare October 17, 2024 05:27
@rvagg rvagg added the skip/changelog This change does not require CHANGELOG.md update label Oct 17, 2024
Copy link
Contributor

@aarshkshah1992 aarshkshah1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@aarshkshah1992 aarshkshah1992 merged commit 16123bc into feat/msg-eth-tx-index Oct 17, 2024
72 of 76 checks passed
@aarshkshah1992 aarshkshah1992 deleted the rvagg/lotus-shed/chainindex branch October 17, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

2 participants