Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(release): v1.29.1 release template improvements #12473

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

BigLep
Copy link
Member

@BigLep BigLep commented Sep 16, 2024

This is for doing release process followups after executing #12470

Checklist

Before you mark the PR ready for review, please make sure that:

@BigLep BigLep self-assigned this Sep 16, 2024
@BigLep BigLep marked this pull request as draft September 16, 2024 19:50
@BigLep BigLep mentioned this pull request Sep 16, 2024
20 tasks
@BigLep
Copy link
Member Author

BigLep commented Sep 16, 2024

This isn't ready for review yet. I'll either work on it today or 2024-09-17. A couple of things:

  1. It didn't have a step for copy/pasting in content to the GitHub release
  2. There was a lot of cruft for when trying to rush out a release.

Added in the things I saw from reading this again after going through it today with v1.29.1
Copy link
Member Author

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rjan90 : I think this is ready for review. I left a couple of extra comments.

I really want to get some minimal tooling that creates the release issue based on these questions:

  1. Is this for a network upgrade? If so, what network version?
  2. Is this a minor release?
  3. Is this a patch release? If yes, what previous release are you patching?
  4. Is this an emergency patch? (If yes, we can skip RC steps)

With that info, I think we can create a release issue for each of these scenarios:

  1. Network upgrade / minor release
  2. non-network upgrade / minor release
  3. normal patch release against previous minor release
  4. normal patch release against current minor release
  5. emergency patch release against previous minor release
  6. emergency patch release against current minor release

I've got a backlog of these type of improvements, so I don't want to commit to it yet, but I think tooling to even start creating the right set of release steps is a good beachhead towards building "lotus releaser" tooling.

documentation/misc/RELEASE_ISSUE_TEMPLATE.md Show resolved Hide resolved
documentation/misc/RELEASE_ISSUE_TEMPLATE.md Show resolved Hide resolved
@BigLep BigLep requested a review from rjan90 September 16, 2024 23:42
@BigLep BigLep marked this pull request as ready for review September 16, 2024 23:42
@BigLep
Copy link
Member Author

BigLep commented Sep 17, 2024

Merging.

Followup issue created on tooling to help with release issue creation: #12477

@BigLep BigLep merged commit 9b86cc5 into master Sep 17, 2024
83 checks passed
@BigLep BigLep deleted the biglep/update-release-process-based-on-v1.29.1 branch September 17, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

2 participants