added league_type = contest to mfl_league #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm. It could be worth reaching out to MFL support to ask if that’s the right way to identify a contest league via API? |
|
It seems like this is the way to go. From the mfl support: "You can just use the "league" API call, and then check the "loadRosters" variable to check if it is a contest style league. It wouldn't make sense for a contest style league to have the dynasty setting, so that shouldn't be an option that you need to check." |
tanho63
reviewed
Sep 29, 2024
|
I added your suggestion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm playing in a mfl contest league and thought, it would be usefull to get this type via
mfl_league().For that, I use the API endpoint
loadRostersif nokeeperTypeis found. I don't know, how robust this is and if someone is playing a keeper contest league or if this is even possible. But maybe this is better than nothing?