fix: move component filtering methods to crates #2892
+348
−370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kate Goldenring <kate.goldenring@fermyon.com>
itowlson
approved these changes
Oct 21, 2024
| @@ -27,6 +29,8 @@ pub const APP_DESCRIPTION_KEY: MetadataKey = MetadataKey::new("description"); | |||
| /// MetadataKey for extracting the OCI image digest. | |||
| pub const OCI_IMAGE_DIGEST_KEY: MetadataKey = MetadataKey::new("oci_image_digest"); | |||
|
|
|||
| type ValidatorFn = dyn Fn(&App, &[String]) -> anyhow::Result<()>; | |||
There was a problem hiding this comment.
As this is used in a public interface, I wonder if it needs a pub or a doc comment or something? I'm not sure what the expectation is with type aliases (and clearly the compiler doesn't mind).
| /// component is configured to to chain to another component that is not | ||
| /// retained. All wildcard service chaining is disallowed and all templated URLs | ||
| /// are ignored. | ||
| pub fn validate_service_chaining_for_components( |
There was a problem hiding this comment.
It might be desirable to give this a more specific name but the doc comment covers it well and the only names I can think of are a bit verbose (e.g. validate_retained_components_include_service_chaining_dependencies!). Not a blocker, just if inspiration strikes!
|
|
||
| [dev-dependencies] | ||
| toml = { workspace = true } | ||
| tempfile = { workspace = true } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves all the component filtering helpers to crates that are accessible to other runtime implementors to prevent code duplication. Also, enables runtimes to pass in extra validating functions.
Thank you @itowlson for pairing on this!
Most of the code is the same. I did change the error message on
validate_service_chaining_for_componentsto not be specific to CLI input.