Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run v0.1.0 of the conformance tests #2697

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Run v0.1.0 of the conformance tests #2697

merged 1 commit into from
Aug 14, 2024

Conversation

rylev
Copy link
Collaborator

@rylev rylev commented Aug 1, 2024

This allows us to evolve the conformance tests without immediately breaking Spin CI.

@rylev rylev requested a review from lann August 1, 2024 13:31
Copy link
Collaborator

@lann lann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it would make sense for the conformance tests versions to follow the Spin version? Maybe just the major/minor numbers; the patch number could be decoupled.

@rylev
Copy link
Collaborator Author

rylev commented Aug 1, 2024

I think that might become difficult to manage for a few reasons:

  • We will likely want to bump the major version of the tests when we introduce a new schema of test description (i.e., the json file that describes the test)
  • Other runtimes will evolve separately and at different paces, and I'm not sure we want the version of Spin CLI to be the thing that ties them together.

I personally think, at least for now, it makes sense for the tests to evolve as they do and not tie them to any external versioning scheme. In the future, we can revisit this question when the rate of change of the tests slows and we have a better picture of how versioning across the entire Spin ecosystem might work.

Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
@rylev rylev merged commit 9982823 into main Aug 14, 2024
34 checks passed
@rylev rylev deleted the versioned-conformance branch August 14, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants