Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert "build: remove lint from CI" #28

Merged
merged 2 commits into from
Jul 30, 2024
Merged

revert "build: remove lint from CI" #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb18fe3
revert "build: remove lint from CI"
igobranco Jul 30, 2024
67d2103
build: no longer run pylint on CI
igobranco Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,8 @@ jobs:
- name: Run unit tests
run: ECOMMERCE_SOURCE_PATH=../ecommerce make -C ecommerce-nau-extensions test

# Can't support multiple named Open edX released of ecommerce and use the commerce lint configuration.
# - name: Run lint
# run: ECOMMERCE_SOURCE_PATH=../ecommerce make -C ecommerce-nau-extensions lint
- name: Run lint
run: ECOMMERCE_SOURCE_PATH=../ecommerce make -C ecommerce-nau-extensions lint

- name: Install gettext package
run: sudo apt-get install -y gettext
Expand Down
3 changes: 2 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,8 @@ lint_pylint: _prerequire
pylint -j 0 --rcfile=pylintrc --verbose --init-hook='import sys; sys.path.append("${ECOMMERCE_SOURCE_PATH}")' $(SRC_FOLDER_FULL_PATH)
.PHONY: lint_pylint

lint: | lint_isort lint_pycodestyle lint_pylint ## Run Python linting
# Can't run pylint from ecommerce externally, the pylint plugins aren't being loaded.
lint: | lint_isort lint_pycodestyle # lint_pylint ## Run Python linting
.PHONY: lint

extract_translations: ## Extract translations from source code
Expand Down