Added _read_mp4box_stem_titles function #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically, for stems which have been created by the NI creator have the titles of the streams in the `udta` metadata. I added the functionality to try to read the stream titles if MP4Box is available, else fall back to original default numbered streams. This is useful if you want to extract wav files using the stem2files, and instead of getting filenames like "stem_0.wav", you can get "Drums.wav" or "Vox.wav" if this information is available in the stem files. The code is taken almost verbatim from the `StemMetadataViewer` class in https://github.com/axeldelafosse/stemgen/blob/master/ni-stem/_internal.py
faroit
reviewed
Jan 15, 2023
|
Nice! |
apt-get update
|
I added But still, the CI failed with some errors in FFmpeg unable to find x264 libraries. |
|
@faroit sorry for the ping -- can you have a look when you have some free time please? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, for stems which have been created by the NI creator have the titles of the streams in the
udtametadata.I added the functionality to try to read the stream titles if MP4Box is available, else fall back to original default numbered streams.
This is useful if you want to extract wav files using the stem2files, and instead of getting filenames like "stem_0.wav", you can get "Drums.wav" or "Vox.wav" if this information is available in the stem files.
The code is taken almost verbatim from the
StemMetadataViewerclass in https://github.com/axeldelafosse/stemgen/blob/master/ni-stem/_internal.py