Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: DO NOT MERGE test: download previous zig version for aarch64 #2128

Closed
wants to merge 1 commit into from

Conversation

LucaGuerra
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Luca Guerra <luca@guerra.sh>
@poiana
Copy link
Contributor

poiana commented Oct 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Perf diff from master - unit tests

     4.49%     +2.78%  [.] next
     1.26%     +0.82%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release
     5.97%     -0.79%  [.] sinsp_evt::get_type
     1.95%     -0.55%  [.] sinsp_evt::get_ts
     0.84%     -0.54%  [.] sinsp_container_info::sinsp_container_info
     0.32%     +0.54%  [.] sinsp_evt::get_direction
     3.01%     -0.51%  [.] sinsp_thread_manager::get_thread_ref
     6.60%     +0.45%  [.] sinsp::next
     1.85%     -0.36%  [.] sinsp::fetch_next_event
     1.11%     -0.36%  [.] libsinsp::events::is_unknown_event

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0185         -0.0185           157           154           157           154
BM_sinsp_split_median                                          -0.0164         -0.0164           157           154           157           154
BM_sinsp_split_stddev                                          -0.3648         -0.3650             1             1             1             1
BM_sinsp_split_cv                                              -0.3529         -0.3530             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.0010         -0.0010            57            57            57            57
BM_sinsp_concatenate_paths_relative_path_median                -0.0042         -0.0043            57            56            57            56
BM_sinsp_concatenate_paths_relative_path_stddev                +1.2307         +1.2327             0             1             0             1
BM_sinsp_concatenate_paths_relative_path_cv                    +1.2329         +1.2348             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     +0.0325         +0.0325            24            25            24            25
BM_sinsp_concatenate_paths_empty_path_median                   +0.0307         +0.0307            24            25            24            25
BM_sinsp_concatenate_paths_empty_path_stddev                   +2.3146         +2.3253             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       +2.2103         +2.2207             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.0159         -0.0159            56            55            56            55
BM_sinsp_concatenate_paths_absolute_path_median                -0.0204         -0.0203            56            55            56            55
BM_sinsp_concatenate_paths_absolute_path_stddev                +0.0839         +0.0839             0             1             0             1
BM_sinsp_concatenate_paths_absolute_path_cv                    +0.1014         +0.1014             0             0             0             0
BM_sinsp_split_container_image_mean                            -0.0059         -0.0059           400           397           400           397
BM_sinsp_split_container_image_median                          -0.0069         -0.0069           400           397           400           397
BM_sinsp_split_container_image_stddev                          -0.6136         -0.6137             3             1             3             1
BM_sinsp_split_container_image_cv                              -0.6113         -0.6114             0             0             0             0

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.46%. Comparing base (90c1520) to head (11f7b3c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2128   +/-   ##
=======================================
  Coverage   74.46%   74.46%           
=======================================
  Files         253      253           
  Lines       33069    33069           
  Branches     5697     5697           
=======================================
+ Hits        24624    24625    +1     
+ Misses       8445     8442    -3     
- Partials        0        2    +2     
Flag Coverage Δ
libsinsp 74.46% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucaGuerra LucaGuerra closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants