Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): bump zig version and improve install-zig action. #2126

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Oct 22, 2024

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area CI

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@FedeDP FedeDP changed the title chore(ci): bump zig version and improve install-zig action. wip: chore(ci): bump zig version and improve install-zig action. Oct 22, 2024
@poiana
Copy link
Contributor

poiana commented Oct 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

github-actions bot commented Oct 22, 2024

Perf diff from master - unit tests

     5.98%     -0.92%  [.] sinsp_evt::get_type
     1.95%     -0.76%  [.] sinsp_evt::get_ts
     3.07%     +0.68%  [.] sinsp_thread_manager::find_thread
     1.69%     -0.62%  [.] libsinsp::sinsp_suppress::process_event
     4.50%     -0.60%  [.] next
     0.84%     -0.59%  [.] sinsp_container_info::sinsp_container_info
     1.38%     -0.55%  [.] scap_event_encode_params_v
     0.53%     +0.52%  [.] scap_next
     4.19%     +0.49%  [.] gzfile_read
     0.47%     +0.47%  [.] sinsp_threadinfo::sinsp_threadinfo

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0353         -0.0355           157           151           157           151
BM_sinsp_split_median                                          -0.0404         -0.0406           157           150           157           150
BM_sinsp_split_stddev                                          +0.4235         +0.4233             1             2             1             2
BM_sinsp_split_cv                                              +0.4756         +0.4757             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.0008         -0.0010            57            57            57            57
BM_sinsp_concatenate_paths_relative_path_median                -0.0046         -0.0048            57            56            57            56
BM_sinsp_concatenate_paths_relative_path_stddev                +0.2760         +0.2725             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    +0.2770         +0.2738             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0039         -0.0041            24            24            24            24
BM_sinsp_concatenate_paths_empty_path_median                   -0.0042         -0.0043            24            24            24            24
BM_sinsp_concatenate_paths_empty_path_stddev                   +0.4428         +0.4376             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       +0.4483         +0.4434             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.0140         -0.0142            56            56            56            56
BM_sinsp_concatenate_paths_absolute_path_median                -0.0142         -0.0143            56            56            56            56
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.7254         -0.7258             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.7215         -0.7218             0             0             0             0
BM_sinsp_split_container_image_mean                            -0.0192         -0.0195           400           392           400           392
BM_sinsp_split_container_image_median                          -0.0229         -0.0232           400           391           400           391
BM_sinsp_split_container_image_stddev                          +0.5501         +0.5475             3             5             3             5
BM_sinsp_split_container_image_cv                              +0.5805         +0.5782             0             0             0             0

LucaGuerra
LucaGuerra previously approved these changes Oct 22, 2024
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.46%. Comparing base (90c1520) to head (db9670c).
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2126   +/-   ##
=======================================
  Coverage   74.46%   74.46%           
=======================================
  Files         253      253           
  Lines       33069    33069           
  Branches     5697     5697           
=======================================
+ Hits        24624    24625    +1     
+ Misses       8445     8444    -1     
Flag Coverage Δ
libsinsp 74.46% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@@ -41,7 +41,7 @@ jobs:
fs.writeFileSync('${{github.workspace}}/pr.zip', Buffer.from(download.data));
- name: 'Unpack artifact'
run:
run: |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:/

…tring.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP FedeDP changed the title wip: chore(ci): bump zig version and improve install-zig action. chore(ci): bump zig version and improve install-zig action. Oct 22, 2024
@poiana poiana merged commit 6322a02 into master Oct 22, 2024
49 checks passed
@poiana poiana deleted the chore/update_zig_action branch October 22, 2024 10:19
@FedeDP
Copy link
Contributor Author

FedeDP commented Oct 22, 2024

/milestone 0.19.0

@poiana poiana added this to the 0.19.0 milestone Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants