Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(driver/bpf): fixed a typo in old ebpf probe code for linux >= 6.11. #2114

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Oct 16, 2024

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area driver-bpf

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
Copy link
Contributor Author

FedeDP commented Oct 16, 2024

/milestone next-driver

@poiana poiana added this to the next-driver milestone Oct 16, 2024
@poiana poiana added the size/XS label Oct 16, 2024
Copy link

Please double check driver/SCHEMA_VERSION file. See versioning.

/hold

@FedeDP
Copy link
Contributor Author

FedeDP commented Oct 16, 2024

/hold
will port the latest-kernel CI to test against arm64 too.

Copy link

github-actions bot commented Oct 16, 2024

Perf diff from master - unit tests

     4.95%     -1.08%  [.] sinsp_parser::process_event
     7.96%     -0.83%  [.] sinsp::next
     3.40%     -0.70%  [.] sinsp_thread_manager::find_thread
     0.56%     +0.68%  [.] sinsp_evt::get_direction
     5.25%     +0.63%  [.] sinsp_evt::get_type
     2.34%     +0.54%  [.] sinsp_thread_manager::get_thread_ref
     8.96%     -0.44%  [.] sinsp_parser::reset
     0.92%     +0.42%  [.] scap_event_encode_params_v
     0.61%     +0.36%  [.] std::_Hashtable<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::__detail::_Identity, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, true, true> >::find
     1.56%     +0.34%  [.] scap_event_decode_params

Heap diff from master - unit tests

peak heap memory consumption: -5.18K
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0585         +0.0586           147           156           147           156
BM_sinsp_split_median                                          +0.0560         +0.0561           148           156           148           156
BM_sinsp_split_stddev                                          -0.6159         -0.6158             1             1             1             1
BM_sinsp_split_cv                                              -0.6371         -0.6370             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0235         +0.0237            56            57            56            57
BM_sinsp_concatenate_paths_relative_path_median                +0.0106         +0.0109            56            57            56            57
BM_sinsp_concatenate_paths_relative_path_stddev                -0.6068         -0.6060             1             1             1             1
BM_sinsp_concatenate_paths_relative_path_cv                    -0.6158         -0.6151             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     +0.0175         +0.0177            25            25            25            25
BM_sinsp_concatenate_paths_empty_path_median                   +0.0160         +0.0163            24            25            24            25
BM_sinsp_concatenate_paths_empty_path_stddev                   +0.0478         +0.0450             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       +0.0298         +0.0269             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.0100         +0.0100            56            56            56            56
BM_sinsp_concatenate_paths_absolute_path_median                +0.0107         +0.0107            56            56            56            56
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.4383         -0.4375             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.4439         -0.4431             0             0             0             0
BM_sinsp_split_container_image_mean                            +0.0028         +0.0028           391           392           391           392
BM_sinsp_split_container_image_median                          +0.0021         +0.0021           391           392           391           392
BM_sinsp_split_container_image_stddev                          +0.9072         +0.9084             1             2             1             2
BM_sinsp_split_container_image_cv                              +0.9019         +0.9032             0             0             0             0

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.69%. Comparing base (c082ec3) to head (cbad4ab).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2114   +/-   ##
=======================================
  Coverage   73.69%   73.69%           
=======================================
  Files         253      253           
  Lines       31916    31916           
  Branches     5608     5613    +5     
=======================================
  Hits        23521    23521           
- Misses       8364     8365    +1     
+ Partials       31       30    -1     
Flag Coverage Δ
libsinsp 73.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poiana poiana added size/M and removed size/XS labels Oct 16, 2024
leogr
leogr previously approved these changes Oct 16, 2024
@FedeDP
Copy link
Contributor Author

FedeDP commented Oct 16, 2024

@leogr still working to improve the CI.
/hold

Copy link

github-actions bot commented Oct 16, 2024

X64 kernel testing matrix

KERNEL CMAKE-CONFIGURE KMOD BUILD KMOD SCAP-OPEN BPF-PROBE BUILD BPF-PROBE SCAP-OPEN MODERN-BPF SCAP-OPEN
amazonlinux2-4.19 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2-5.10 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2-5.15 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2-5.4 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2022-5.15 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2023-6.1 🟢 🟢 🟢 🟢 🟢 🟢
archlinux-6.0 🟢 🟢 🟢 🟢 🟢 🟢
archlinux-6.7 🟢 🟢 🟢 🟢 🟢 🟢
centos-3.10 🟢 🟢 🟢 🟡 🟡 🟡
centos-4.18 🟢 🟢 🟢 🟢 🟢 🟢
centos-5.14 🟢 🟢 🟢 🟢 🟢 🟢
fedora-5.17 🟢 🟢 🟢 🟢 🟢 🟢
fedora-5.8 🟢 🟢 🟢 🟢 🟢 🟢
fedora-6.2 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-3.10 🟢 🟢 🟢 🟡 🟡 🟡
oraclelinux-4.14 🟢 🟢 🟢 🟢 🟢 🟡
oraclelinux-5.15 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-5.4 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-4.15 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-5.8 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-6.5 🟢 🟢 🟢 🟢 🟢 🟢

ARM64 kernel testing matrix

KERNEL CMAKE-CONFIGURE KMOD BUILD KMOD SCAP-OPEN BPF-PROBE BUILD BPF-PROBE SCAP-OPEN MODERN-BPF SCAP-OPEN
amazonlinux2-5.4 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2022-5.15 🟢 🟢 🟢 🟢 🟢 🟢
fedora-6.2 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-4.14 🟢 🟢 🟢 🟡 🟡 🟡
oraclelinux-5.15 🟢 🟢 🟢 🟢 🟢 🟢
ubuntu-6.5 🟢 🟢 🟢 🟢 🟢 🟢

Molter73
Molter73 previously approved these changes Oct 16, 2024
Copy link
Contributor

@Molter73 Molter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Oct 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, Molter73

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FedeDP FedeDP dismissed stale reviews from Molter73 and leogr via cb53fe1 October 16, 2024 09:27
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
Copy link
Contributor Author

FedeDP commented Oct 16, 2024

Ok i expanded the latest-kernel CI to test the build on arm64 too: https://github.com/falcosecurity/libs/actions/runs/11363216135/job/31606690972

/unhold

@FedeDP
Copy link
Contributor Author

FedeDP commented Oct 16, 2024

cc @leogr @Molter73

@poiana poiana merged commit 138e70e into master Oct 16, 2024
58 of 60 checks passed
@poiana poiana deleted the fix/bpf_probe_typo branch October 16, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants