Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(cmake): updated c-ares to latest 1.33.1 version. #2034

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Aug 29, 2024

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area build

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Also, now c-ares supports cmake, therefore make use of it.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

This should help resolving a build issue in falcosecurity/falco#3307.
While not fundamental for now, it is a nice to have.

Does this PR introduce a user-facing change?:

NONE

Copy link

github-actions bot commented Aug 29, 2024

Perf diff from master - unit tests

     4.81%     -0.97%  [.] sinsp_parser::process_event
     3.73%     -0.94%  [.] sinsp_thread_manager::find_thread
     1.98%     -0.73%  [.] libsinsp::sinsp_suppress::process_event
     1.64%     +0.72%  [.] scap_event_decode_params
     1.08%     +0.72%  [.] libsinsp::events::is_unknown_event
     4.58%     -0.59%  [.] sinsp_evt::load_params
    10.91%     +0.53%  [.] sinsp_parser::reset
     0.91%     -0.42%  [.] sinsp_evt::get_param
     1.29%     +0.42%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>
     1.30%     -0.41%  [.] sinsp_parser::event_cleanup

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0150         +0.0150           146           149           146           149
BM_sinsp_split_median                                          +0.0122         +0.0122           147           149           147           149
BM_sinsp_split_stddev                                          -0.8879         -0.8881             2             0             2             0
BM_sinsp_split_cv                                              -0.8896         -0.8898             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.0471         -0.0471            47            45            47            45
BM_sinsp_concatenate_paths_relative_path_median                -0.0362         -0.0362            47            45            47            45
BM_sinsp_concatenate_paths_relative_path_stddev                +0.1664         +0.1671             1             1             1             1
BM_sinsp_concatenate_paths_relative_path_cv                    +0.2241         +0.2248             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0162         -0.0162            17            17            17            17
BM_sinsp_concatenate_paths_empty_path_median                   -0.0174         -0.0174            17            17            17            17
BM_sinsp_concatenate_paths_empty_path_stddev                   +0.1716         +0.1713             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       +0.1909         +0.1905             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.0649         -0.0649            49            46            49            46
BM_sinsp_concatenate_paths_absolute_path_median                -0.0623         -0.0623            49            46            49            46
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.7982         -0.7979             1             0             1             0
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.7842         -0.7838             0             0             0             0
BM_sinsp_split_container_image_mean                            +0.1052         +0.1053           344           380           344           380
BM_sinsp_split_container_image_median                          +0.1060         +0.1061           344           381           344           381
BM_sinsp_split_container_image_stddev                          +1.3652         +1.3631             1             2             1             2
BM_sinsp_split_container_image_cv                              +1.1400         +1.1380             0             0             0             0

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.57%. Comparing base (215db2d) to head (87f03c0).
Report is 17 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2034   +/-   ##
=======================================
  Coverage   73.57%   73.57%           
=======================================
  Files         253      253           
  Lines       31860    31860           
  Branches     5640     5648    +8     
=======================================
  Hits        23442    23442           
- Misses       8407     8417   +10     
+ Partials       11        1   -10     
Flag Coverage Δ
libsinsp 73.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FedeDP
Copy link
Contributor Author

FedeDP commented Aug 29, 2024

/milestone TBD

@poiana poiana added this to the TBD milestone Aug 29, 2024
FedeDP added a commit to falcosecurity/falco that referenced this pull request Aug 29, 2024
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
Copy link
Contributor Author

FedeDP commented Aug 29, 2024

/milestone 0.19.0

@poiana poiana modified the milestones: TBD, 0.19.0 Aug 29, 2024
Andreagit97
Andreagit97 previously approved these changes Sep 5, 2024
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Sep 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

FedeDP added a commit to falcosecurity/falco that referenced this pull request Sep 10, 2024
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@poiana poiana merged commit a9421ba into master Sep 20, 2024
46 of 47 checks passed
@poiana poiana deleted the update/c-ares branch September 20, 2024 08:10
FedeDP added a commit to falcosecurity/falco that referenced this pull request Sep 23, 2024
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
FedeDP added a commit to falcosecurity/falco that referenced this pull request Sep 23, 2024
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
FedeDP added a commit to falcosecurity/falco that referenced this pull request Sep 30, 2024
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants