fix(driver/configure): properly pass CC variable as make argument.
#1873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
release-note-none
kind/bug
|
/milestone 7.2.0+driver |
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
FedeDP
force-pushed
the
fix/kmod_config_pass_CC
branch
from
5ded26a
to
b8dcc5c
Compare
LucaGuerra
approved these changes
May 17, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, LucaGuerra, Molter73 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area driver-kmod
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Some distros (namely ubuntu and debian as far as i know) do not accept
CCbeing passed from env.Instead, they want it to be passed as
makeargument.Make sure to pass it both way in the configure modules for kmod (
CCis already passed as env, therefore we just add it tomakeargument too !)Which issue(s) this PR fixes:
falco-driver-loaderbuilding of drivers on ubuntu.Fixes #
Special notes for your reviewer:
I already saw something similar on driverkit a couple of months ago: falcosecurity/driverkit#322 (comment)
Does this PR introduce a user-facing change?: