Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vote: update(owners): add LucaGuerra to owners #332

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

LucaGuerra
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind documentation

Any specific area of the project related to this PR?

/area docs

What this PR does / why we need it:

As a Falco core maintainer I would like to assist with testing, reviewing and improving our driver building tooling. I am familiar with this project which is getting more activity and I could lend a hand following the issues reported by current project maintainers, if you agree.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Luca Guerra <luca@guerra.sh>
@poiana poiana added dco-signoff: yes kind/documentation Improvements or additions to documentation area/docs labels Apr 3, 2024
@poiana poiana requested review from leodido and Lowaiz April 3, 2024 09:44
@poiana poiana added the size/XS label Apr 3, 2024
@FedeDP
Copy link
Contributor

FedeDP commented Apr 3, 2024

Big +1 from me, i think a new maintainer is good for the vitality of the project!
/cc @dwindsor @EXONER4TED

@FedeDP
Copy link
Contributor

FedeDP commented Apr 3, 2024

/hold

@dwindsor
Copy link
Contributor

dwindsor commented Apr 3, 2024

Definitely +1 from me!

@EXONER4TED
Copy link
Contributor

Heck yea! +1 from me 🚀

@FedeDP
Copy link
Contributor

FedeDP commented Apr 11, 2024

As per our governance, this majority vote was successful since we got more votes in favor than against, and more than one week has passed.

/approve

@poiana
Copy link

poiana commented Apr 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Apr 11, 2024

LGTM label has been added.

Git tree hash: 15bf9fc820f64c52caaa07064d850cfd20dd3975

@FedeDP
Copy link
Contributor

FedeDP commented Apr 11, 2024

/unhold

@poiana poiana merged commit 8276af8 into master Apr 11, 2024
5 checks passed
@poiana poiana deleted the update/add-lucaguerra-owners branch April 11, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants