-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is probable prime #32
Open
KingAkeem
wants to merge
13
commits into
faheel:master
Choose a base branch
from
KingAkeem:is_probable_prime
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
83d4971
Adding Little Fermat Theorem
0650ee8
Fixed issue with sed command being different on GNU vs. OSX using '.hpp'
58e673a
Finished implementing Little Fermat's Theorem, Rabin Miller is next
KingAkeem c5bcbde
Merge branch 'master' of github.com:faheel/BigInt into is_probable_prime
KingAkeem 773c667
Adding Rabin-Miller theory
KingAkeem 59927ec
Finished implementing Rabin-Miller Primality test
KingAkeem 0a8eba1
Added test for base case of is_probable_prime
KingAkeem d58e8d2
Renaming vars
KingAkeem c59028a
Removing unnecessary define statements
KingAkeem f6a56ac
Fixing spacing
KingAkeem 5028105
Fixing spacing
KingAkeem e1eda6f
Replacing all occurences of a with rand_num
KingAkeem 5b4919a
Adding more extensive testing for is_probable_prime
KingAkeem File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about larger cases? Can you check that it returns
true
for the following prime numbers:and
false
for the following composite numbers:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't test because Binary Arithmetic Tests are failing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is because
a
is not declared. I think you forgot to replace all instances ofa
torand_num
.