Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed duplicate step from SETUP_INSTRUCTIONS.md #172

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Removed duplicate step from SETUP_INSTRUCTIONS.md #172

wants to merge 2 commits into from

Conversation

SamerMakni
Copy link

Duplicate step ?

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 28, 2024
@KavitShah1998
Copy link
Contributor

Thank you @SamerMakni for raising this cleanup PR

KavitShah1998
KavitShah1998 approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@KavitShah1998 KavitShah1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KavitShah1998 KavitShah1998 added the documentation Improvements or additions to documentation label Aug 7, 2024
@KavitShah1998
Copy link
Contributor

Seems like there is some configuration issue in the PR due to which it is not allowing circle-ci pre-commit.

Will try to re-open another PR from @SamerMakni 's patch-2 branch and see if that resolves it.

@KavitShah1998 KavitShah1998 reopened this Aug 7, 2024
@KavitShah1998
Copy link
Contributor

@SamerMakni
The configuration of this repository disables running circle-ci pre-commit for forks.
I see that your PR is raised from SamerMakni:patch-2

Could you please try to create a branch inside main repo, push your changes there and raise your PR into main from that branch?

We wouldn't be able to merge until circle-ci passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmytyyang jimmytyyang jimmytyyang approved these changes

@KavitShah1998 KavitShah1998 KavitShah1998 approved these changes

Assignees

@SamerMakni SamerMakni

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SamerMakni @KavitShah1998 @jimmytyyang @facebook-github-bot