Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2347. Reimplement duties controller.rb and badges controller.rb #39

Open
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

sankettangade
Copy link

@sankettangade sankettangade commented Apr 25, 2023

This is only a Backend Change project hence, there is no link for the hosted application. Also, we have done Swagger UI API testing for testing the API endpoints

@mundra-ankur mundra-ankur self-requested a review April 27, 2023 12:19
@mundra-ankur
Copy link
Member

This is only a Backend Change project hence, there is no link for the hosted application. Also, we have done Swagger UI API testing for testing the API endpoints

You can still host the backend server as an API server where APIs can be tested.

Copy link
Member

@mundra-ankur mundra-ankur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, it looks like there are a lot of changes required before this work can be merged. I noticed that there doesn't seem to be any testing done (API), and it appears that the guidelines may not have been followed. While I added a few review comments, there are still many other issues in other files that need to be addressed. Please make sure to follow the guidelines and make the appropriate changes.

Gemfile.lock Show resolved Hide resolved
app/controllers/api/v1/badges_controller.rb Show resolved Hide resolved
app/controllers/api/v1/badges_controller.rb Show resolved Hide resolved
app/controllers/api/v1/badges_controller.rb Outdated Show resolved Hide resolved
app/controllers/api/v1/badges_controller.rb Outdated Show resolved Hide resolved
app/controllers/api/v1/badges_controller.rb Outdated Show resolved Hide resolved
config/database.yml Show resolved Hide resolved
config/database.yml.example Show resolved Hide resolved
@@ -0,0 +1,20 @@
class Badge < ApplicationRecord

def self.get_id_from_name(badge_name)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please help me locate where we have utilized this class method and other methods in this model? I am having difficulty finding its application.

app/models/duty.rb Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants