-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2314 & E2338 - Reimplement the response_map hierarchy #21
Open
sbiyer
wants to merge
10
commits into
expertiza:main
Choose a base branch
from
sbiyer:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Mar 21, 2023
-
* E2314 - add classes relevant to this project * E2314 - update database configuration * E2314 - update database configuration * E2314 - update database configuration * E2314 - update database configuration * E2314 - migrate ResponseMap class methods to Response class - assessments_for - reviewer_assessments_for * E2314 - change comparator function to use rocket implementation * E2314 - migrate get_responses_for_team_round function to Response class * E2314 - adhere to ruby convention by dropping get prefix on methods * E2314 - adhere to ruby convention by dropping get prefix on methods * E2314 - add DB migrate script for creating response map table * E2314 - remove default columns from create table definition * E2314 - move rocket implementation to Response because that's where comparison is needed * E2314 - remove dead code which is not used in expertiza implementation * E2314 - add dependent classes for unit test scaffolding - add unit tests for teammate_review_response_map * E2314 - add unit tests for review_response_map * E2314 - add unit tests for response_map * E2314 - add unit tests for feedback_response_map * E2314 - add comments - update variable names & function names to be more meaningful - update broken tests
Configuration menu - View commit details
-
Copy full SHA for 730bc23 - Browse repository at this point
Copy the full SHA 730bc23View commit details
Commits on Mar 28, 2023
-
* E2314 - fix feedback_response_map_report size - Fixed the size of feedback_response_map function size * Added Comments and tests for response_map_test. * Bug fix in test response_map_test --------- Co-authored-by: Aswin Itha <89421200+ithaaswin@users.noreply.github.com> Co-authored-by: suparnosaha <suparnosaha@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7d9186f - Browse repository at this point
Copy the full SHA 7d9186fView commit details
Commits on Apr 23, 2023
-
implementing visitor's pattern for email
ssaha7 committedApr 23, 2023 Configuration menu - View commit details
-
Copy full SHA for 59e493b - Browse repository at this point
Copy the full SHA 59e493bView commit details -
ssaha7 committed
Apr 23, 2023 Configuration menu - View commit details
-
Copy full SHA for 0343f53 - Browse repository at this point
Copy the full SHA 0343f53View commit details
Commits on Apr 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ccfc796 - Browse repository at this point
Copy the full SHA ccfc796View commit details -
Configuration menu - View commit details
-
Copy full SHA for 68fb25f - Browse repository at this point
Copy the full SHA 68fb25fView commit details -
* Update feedback_response_map.rb * scoring is included instead of extending * Removing unwanted methods in response_map.rb * adding round parameter in prepare_final_review_version * Iterator pattern implemented in report_by_round * Iterator pattern in the responses_for_team_round * Visitor pattern implemented for Email method * Iterators added * Srini e2338 (#11) * implementing visitor's pattern for email * reverting changes in main * E2338 - fix typo that caused unit test failures * E2338 - refactor visitor pattern - fix broken tests --------- Co-authored-by: ssaha7 <ssaha7@ncsu.edu> * Srini e2338 (#12) * implementing visitor's pattern for email * reverting changes in main * E2338 - fix typo that caused unit test failures * E2338 - refactor visitor pattern - fix broken tests * E2338 - add comments to test cases * E2338 - fix test warnings after pull latest --------- Co-authored-by: ssaha7 <ssaha7@ncsu.edu> * E2338 - add visitor pattern tests for email functionality --------- Co-authored-by: Aswin Itha <89421200+ithaaswin@users.noreply.github.com> Co-authored-by: Suparno Saha <37995798+suparnosaha@users.noreply.github.com> Co-authored-by: ssaha7 <ssaha7@ncsu.edu> Co-authored-by: Aswin Itha <aitha@ncsu.edu>
Configuration menu - View commit details
-
Copy full SHA for bcbe877 - Browse repository at this point
Copy the full SHA bcbe877View commit details
Commits on Apr 29, 2023
-
Renaming classes According to functionalities
ssaha7 committedApr 29, 2023 Configuration menu - View commit details
-
Copy full SHA for 50fc9da - Browse repository at this point
Copy the full SHA 50fc9daView commit details -
Configuration menu - View commit details
-
Copy full SHA for aa57178 - Browse repository at this point
Copy the full SHA aa57178View commit details -
Merge pull request #13 from sbiyer/suparno_changes
Renaming classes According to Demo Feedback
Configuration menu - View commit details
-
Copy full SHA for 5944d3d - Browse repository at this point
Copy the full SHA 5944d3dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.