Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2314 & E2338 - Reimplement the response_map hierarchy #21

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Commits on Mar 21, 2023

  1. E2314 (#1)

    * E2314
    - add classes relevant to this project
    
    * E2314
    - update database configuration
    
    * E2314
    - update database configuration
    
    * E2314
    - update database configuration
    
    * E2314
    - update database configuration
    
    * E2314
    - migrate ResponseMap class methods to Response class
       - assessments_for
       - reviewer_assessments_for
    
    * E2314
    - change comparator function to use rocket implementation
    
    * E2314
    - migrate get_responses_for_team_round function to Response class
    
    * E2314
    - adhere to ruby convention by dropping get prefix on methods
    
    * E2314
    - adhere to ruby convention by dropping get prefix on methods
    
    * E2314
    - add DB migrate script for creating response map table
    
    * E2314
    - remove default columns from create table definition
    
    * E2314
    - move rocket implementation to Response because that's where comparison is needed
    
    * E2314
    - remove dead code which is not used in expertiza implementation
    
    * E2314
    - add dependent classes for unit test scaffolding
    - add unit tests for teammate_review_response_map
    
    * E2314
    - add unit tests for review_response_map
    
    * E2314
    - add unit tests for response_map
    
    * E2314
    - add unit tests for feedback_response_map
    
    * E2314
    - add comments
    - update variable names & function names to be more meaningful
    - update broken tests
    sbiyer authored Mar 21, 2023
    Configuration menu
    Copy the full SHA
    730bc23 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2023

  1. Address Review Feedback (#9)

    * E2314 - fix feedback_response_map_report size
    
    - Fixed the size of feedback_response_map function size
    
    * Added Comments and tests for response_map_test.
    
    * Bug fix in test response_map_test
    
    ---------
    
    Co-authored-by: Aswin Itha <89421200+ithaaswin@users.noreply.github.com>
    Co-authored-by: suparnosaha <suparnosaha@gmail.com>
    3 people authored Mar 28, 2023
    Configuration menu
    Copy the full SHA
    7d9186f View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2023

  1. implementing visitor's pattern for email

    ssaha7 committed Apr 23, 2023
    Configuration menu
    Copy the full SHA
    59e493b View commit details
    Browse the repository at this point in the history
  2. reverting changes in main

    ssaha7 committed Apr 23, 2023
    Configuration menu
    Copy the full SHA
    0343f53 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2023

  1. E2338

    - fix typo that caused unit test failures
    sbiyer committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    ccfc796 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    68fb25f View commit details
    Browse the repository at this point in the history
  3. E2338 (#10)

    * Update feedback_response_map.rb
    
    * scoring is included instead of extending
    
    * Removing unwanted methods in response_map.rb
    
    * adding round parameter in prepare_final_review_version
    
    * Iterator pattern implemented in report_by_round
    
    * Iterator pattern in the responses_for_team_round
    
    * Visitor pattern implemented for Email method
    
    * Iterators added
    
    * Srini e2338 (#11)
    
    * implementing visitor's pattern for email
    
    * reverting changes in main
    
    * E2338
    - fix typo that caused unit test failures
    
    * E2338
    - refactor visitor pattern
    - fix broken tests
    
    ---------
    
    Co-authored-by: ssaha7 <ssaha7@ncsu.edu>
    
    * Srini e2338 (#12)
    
    * implementing visitor's pattern for email
    
    * reverting changes in main
    
    * E2338
    - fix typo that caused unit test failures
    
    * E2338
    - refactor visitor pattern
    - fix broken tests
    
    * E2338
    - add comments to test cases
    
    * E2338
    - fix test warnings after pull latest
    
    ---------
    
    Co-authored-by: ssaha7 <ssaha7@ncsu.edu>
    
    * E2338
    - add visitor pattern tests for email functionality
    
    ---------
    
    Co-authored-by: Aswin Itha <89421200+ithaaswin@users.noreply.github.com>
    Co-authored-by: Suparno Saha <37995798+suparnosaha@users.noreply.github.com>
    Co-authored-by: ssaha7 <ssaha7@ncsu.edu>
    Co-authored-by: Aswin Itha <aitha@ncsu.edu>
    5 people authored Apr 24, 2023
    Configuration menu
    Copy the full SHA
    bcbe877 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2023

  1. Renaming classes According to functionalities

    ssaha7 committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    50fc9da View commit details
    Browse the repository at this point in the history
  2. E2338

    - fix tests after demo feedback changes
    sbiyer committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    aa57178 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #13 from sbiyer/suparno_changes

    Renaming classes According to Demo Feedback
    suparnosaha authored Apr 29, 2023
    Configuration menu
    Copy the full SHA
    5944d3d View commit details
    Browse the repository at this point in the history