fix(target-test-base): Fix workflow dispatch strategy #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tomassebestik
commented
Aug 21, 2023
•
tomassebestik
commented
- removed automatic build and push image on push to PR or master, strategy didn't work and was hard to understand
- now entire GH action triggered only manually
- updated versions of used external GH actions to address warning in build pipeline
tomassebestik
force-pushed
the
fix/target-test-base-workflow-dispatch
branch
7 times, most recently
from
6c19615
to
2268e6f
Compare
tomassebestik
force-pushed
the
fix/target-test-base-workflow-dispatch
branch
from
2268e6f
to
1e4d59c
Compare
|
@fhrbata Can I ask you for quick review? It is based on your idea in https://github.com/espressif/idf-python-wheels/blob/main/.github/workflows/build-wheels-ad-hoc.yml. Many thanks! |
fhrbata
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
@tomassebestik I'm not going to pretend I understand it all, but FWIW it looks ok to me :). My apologies for the delay and thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.