-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add target-test-base images #6
Conversation
20190e8
to
4135268
Compare
4135268
to
b542349
Compare
5a084a2
to
65ab6d1
Compare
@hfudev @antmak @dobairoland @radimkarnis PTAL (sorry for branching the discussion between the Gitlab repo and this GH, but I think it makes sense ...) I tested on both Note that block:
... it basically doing this: For example, when installing cryptography using
You can test this (on any architecture) by:
|
I remember that "prefer binary" wasn't a good enough solution for all scenarios of using cryptography. That is why we use the "only binary" option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @tomassebestik! LGTM.
@dobairoland I remember that too... but surprisingly, it's working here now (and also in GL build job): $ docker run --rm -it ghcr.io/espressif/github-esp-dockerfiles/target-test-base-jammy:py3.8.17
root@e9d68a1050f4:/# pip install cryptography
Looking in indexes: https://dl.espressif.com/pypi/, https://pypi.org/simple
Collecting cryptography
Downloading https://dl.espressif.com/pypi/cryptography/cryptography-40.0.2-cp38-cp38-linux_armv7l.whl (1.5 MB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.5/1.5 MB 8.6 MB/s eta 0:00:00
Collecting cffi>=1.12 (from cryptography)
Downloading https://dl.espressif.com/pypi/cffi/cffi-1.15.1-cp38-cp38-linux_armv7l.whl (397 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 397.8/397.8 kB 7.9 MB/s eta 0:00:00
Collecting pycparser (from cffi>=1.12->cryptography)
Downloading pycparser-2.21-py2.py3-none-any.whl (118 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 118.7/118.7 kB 1.8 MB/s eta 0:00:00
Installing collected packages: pycparser, cffi, cryptography
Successfully installed cffi-1.15.1 cryptography-40.0.2 pycparser-2.21
root@e9d68a1050f4:/# uname -a
Linux e9d68a1050f4 5.10.17-v7+ #1421 SMP Thu May 27 13:59:01 BST 2021 armv7l armv7l armv7l GNU/Linux (pulling older version of Maybe using Anyway ... when package is set with |
This PR creates pre-build Docker images that can be used as base image (
FROM: ghcr.io/espressif/github-esp-dockerfiles/target-test-base-jammy:py3.8.17
for thetarget-test-env
production image.The goal is to have this image ready with all Python versions for future updates in GHCR.
This repository is public, so image can be pulled from anywhere by anyone. Building this image on GitHub is faster and easier than doing the same on our Gitlab Docker build runner, and downloading this image does not require any token or special access.
The main features of these images
3.8
,3.9
,3.10
,3.11
)amd64
) and RaspberryPI 32bit (arm
)workflow dispatch:
(will work after this PR merged to master)pip
prefers our registry (https://dl.espressif.com/pypi/) with Python wheels over PyPi.org (https://pypi.org/simple)pip
prefers binary (wheel, even lower version) over compiling from source codeRelated