Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scope for undefined ESMX_EXE_NAME #162

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Fix scope for undefined ESMX_EXE_NAME #162

merged 1 commit into from
Jul 13, 2023

Conversation

danrosen25
Copy link
Member

Fix the scope for ESMX_EXE_NAME when exe_name is not set in esmxBuild.yaml file.

@danrosen25 danrosen25 requested a review from theurich July 13, 2023 18:16
theurich
theurich approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@theurich theurich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked with the CMake documentation, and indeed, it does need both calls to set the variable in the local and parent scope. Looks good now.

@danrosen25 danrosen25 merged commit 6ae911f into release/8.5.0 Jul 13, 2023
2 checks passed
@theurich theurich deleted the fix/esmx_exe_name branch July 13, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theurich theurich theurich approved these changes

Assignees

@theurich theurich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danrosen25 @theurich