Fix for writing mda files to subdirectories on Linux #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from the stat call while the filename remains unchanged.
|
This PR has been tested on RHEL9 and Windows 11 with base-7.0.8. saveData was able to write data to the correct subdirectories, as well as to the file system path when the subdirectory was blank. |
|
I'm ok with this fix. |
prjemian
reviewed
Jul 24, 2024
| @@ -719,23 +719,32 @@ LOCAL int fileStatus(char* fname) | |||
| { | |||
| struct stat status; | |||
| int retVal; | |||
|
|
|||
There was a problem hiding this comment.
remove the trailing whitespace
There was a problem hiding this comment.
This whitespace makes the indentation consistent across the entire function (see attached screenshot).
keenanlang
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a local copy of the filename so trailing slashes can be excluded from the stat call while the filename remains unchanged.
Fixes #32