Add a disconnect_reason method to Connection
#248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is useful in some applications to know why the connection was disconnected. This keeps track of the disconnection reason provided by the Softdevice and returns it in the `DisconnectedError`. A new method `Connection::disconnect_with_reason()` has also been added to allow the user to indicate the reason for a locally initiated disconnection to the remote device.
Allows the `Disconnected` state to be represented by all zeros so `ConnectionState` can be put in bss.
L2cap errors are omitted due to ambiguity between channel disconnection vs connection disconnection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is useful in some applications to know why the connection was disconnected. This keeps track of the disconnection reason provided by the Softdevice and allows the application to query it.
A new method
Connection::disconnect_with_reason()has also been added to allow the user to indicate the reason for a locally initiated disconnection to the remote device.