-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build docker image #180
Merged
Merged
Build docker image #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thbkrkr
force-pushed
the
build-docker-image
branch
5 times, most recently
from
September 22, 2023 08:08
6030138
to
a45f610
Compare
thbkrkr
force-pushed
the
build-docker-image
branch
2 times, most recently
from
September 22, 2023 08:51
cdf855f
to
c2299fd
Compare
thbkrkr
force-pushed
the
build-docker-image
branch
from
September 22, 2023 09:53
c2299fd
to
991bd95
Compare
pebrc
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested on macOS. Awesome shell script wizardry 🪄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the Buildkite pipeline to release a container image that contains the multiple eck-diagnostics tool binaries.
The container image is built and pushed using drivah. The tag is defined using
BUILDKITE_TAG
if set elseBUILDKITE_COMMIT:0:8
. The tag is used to set the buildVersion in the tool.Release when a git tag exists:
Else:
Two scripts
entrypoint.sh
andget.sh
are used in the image to make it easier to understand how to extract binaries.Flow in CI:
drivah.toml.sh -> Dockerfile -> make build-binary
.Flow in dev:
make build-image -> drivah.toml.sh -> Dockerfile -> make build-binary
.Testing:
Message displayed when the image is called without argument:
First call without
| sh
to check the content of the script:Let's copy the binary: